Retain complete PHPUnit failure artifacts - #2498
Merged
Merged
Conversation
chubes4
marked this pull request as ready for review
September 10, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain PHPUnit JUnit XML as a bounded, redacted artifact before runtime teardown on success and failure. Test-results and the manifest reference the artifact with
application/junit+xmland SHA-256, while command failure responses remain bounded.Clear prior reports before each invocation and validation path so a failed or discovery-only command cannot reuse stale testcase evidence. Capture failures retain structured diagnostics. The capture bound applies to retained output; the Playground text-read API does not itself bound allocation before reading.
Verification
f09b8b5117990c199aa0fced150e2f2322de8742: all five GitHub checks passed.Reproduction: normal
npm ci(including postinstall),npm run build, thennpx tsx tests/phpunit-structured-evidence.test.ts,npx tsx tests/phpunit-result-paths.test.ts, andnpx tsx tests/playground-phpunit-readonly-cache.integration.test.ts.Supports Automattic/markdown-database-integration#393 and #377. No release or deployment.
AI Assistance
GPT-6 Astra (
openai/gpt-6-astra) and GPT-5.6 Terra (openai/gpt-5.6-terra) via OpenCode implemented and verified the capture changes. Astra reviewed stale-output handling and bounds, independently checked real native/MySQL artifacts and final CI, and finalized the PR under Chris Huber's direction.