Fix account move verification and notify followers

[pfefferle]

Proposed changes:

Reviewed the outgoing Move handling (Move::externally() / Move::internally()) against FEP-7628 and fixed four things:

• Verify before advertising. externally() set movedTo before fetching and checking the target, so a failed or unverifiable move left the actor pointing at a destination with no Move federated. movedTo is now written only after the target is verified.
• Verify the id we actually send. The link check now tests the actor id sent as the Move's object (get_id()) against the target's alsoKnownAs, instead of the possibly non-canonical input URL, which is what receiving servers verify against.
• alsoKnownAs on the target. internally() recorded the old URL on the source actor. It now records it on the target, so the new actor links back to the old one and receiving servers accept the move. For a domain change the two resolve to the same actor, so that path is unchanged; for a move between two different local actors the target now links back.
• Notify followers (FEP-7628). After a move, the actor's profile is federated as an Update so followers refresh the cached movedTo/alsoKnownAs. It is queued after the Move so a follower that reacts to movedTo still processes the migration first.

Delivery is unchanged and already matches FEP-7628: the Move is addressed to the old actor's followers.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• wp activitypub move <from> <to> (WP-CLI) or trigger a move via the settings.
• An external move to a target whose alsoKnownAs does not list your actor is rejected and leaves movedTo unset.
• A verified move sets movedTo, federates the Move to followers, and federates a profile Update.
• A domain change still migrates every actor as before.

Changelog entry

The changelog entry is already included in the branch (.github/changelog/fix-account-move-verification), so the auto-create box below is left unchecked.

Changelog Entry Details

Significance

• Patch

Type

• Fixed - for any bug fixes

Message

Fix Fediverse account migration so a move is verified before it takes effect and reliably reaches your followers on other servers.

[Copilot]

Pull request overview

Improves outgoing ActivityPub account migration (Move) handling to better align with FEP-7628 by verifying targets before persisting movedTo, ensuring link-back validation uses the canonical actor id, and notifying followers via a profile Update after a move.

Changes:

• Adjust Move::externally() to validate the target’s alsoKnownAs against the canonical actor id and only persist movedTo after verification.
• Adjust Move::internally() to record the source URL on the target actor’s alsoKnownAs (so the new actor links back).
• Add/extend PHPUnit coverage for verified moves, rejected targets, internal moves between distinct local users, and profile-update federation; add changelog entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
includes/class-move.php	Updates external/internal move validation and adds follower-notification via profile Update scheduling.
tests/phpunit/tests/includes/class-test-move.php	Expands tests for verification behavior, follower notification, and internal moves across distinct users.
.github/changelog/fix-account-move-verification	Adds a patch-level changelog entry describing the migration fix.

Comments suppressed due to low confidence (4)

includes/class-move.php:193

• schedule_profile_update() runs even when add_to_outbox() fails, which can result in profile Updates being federated without a corresponding Move activity.

		$outbox_id = add_to_outbox( $activity, null, $user->get__id(), ACTIVITYPUB_CONTENT_VISIBILITY_QUIET_PUBLIC );

		/*
		 * Notify followers of the changed profile on both actors by federating an Update (FEP-7628).
		 * Queued after the Move so a follower that reacts to `movedTo` still processes the migration first.

tests/phpunit/tests/includes/class-test-move.php:109

• This pre_http_request filter callback is registered with the default accepted-args (1), but the closure declares 0 parameters. That produces “too many arguments” warnings on PHP 7.x and can become an ArgumentCountError on PHP 8+.

		$filter = function () use ( $from ) {

tests/phpunit/tests/includes/class-test-move.php:149

• This pre_http_request filter callback is registered with the default accepted-args (1), but the closure declares 0 parameters. That produces “too many arguments” warnings on PHP 7.x and can become an ArgumentCountError on PHP 8+.

		$filter = function () {

tests/phpunit/tests/includes/class-test-move.php:205

• This pre_http_request filter callback is registered with the default accepted-args (1), but the closure declares 0 parameters. That produces “too many arguments” warnings on PHP 7.x and can become an ArgumentCountError on PHP 8+.

		$filter = function () use ( $from ) {