Skip to content

fix(data-liberation): preserve hydrated video sources - #4796

Closed
chubes4 wants to merge 18 commits into
trunkfrom
fix/cindyjoy-runtime-video-capture
Closed

fix(data-liberation): preserve hydrated video sources#4796
chubes4 wants to merge 18 commits into
trunkfrom
fix/cindyjoy-runtime-video-capture

Conversation

@chubes4

@chubes4 chubes4 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • serializes runtime-populated video sources during page capture
  • waits only while source-less videos explicitly report pending hydration
  • adds bounded hydration-wait coverage

Testing

  • npm run test --workspace=data-liberation -- --run src/lib/screenshot/screenshotter.test.ts
  • npm run build --workspace=data-liberation

Handoff

This is the upstream DLA capture change. The recaptured Cindy Joy artifact contains six Wix MP4 sources. The current Blocks Engine artifact path subsequently strips unstaged video asset URLs, so end-to-end import remains blocked on media asset staging.

Disclosure

Authored with GPT-5.6 Terra via OpenCode, orchestrated by GPT-6 Astra via OpenCode.

@chubes4

chubes4 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by the hydrated-video fix merged upstream in Automattic/data-liberation-agent#169 (4290f0b2), now included with its regression test in draft #3952. Closing this duplicate implementation PR; #3952 remains draft, so this does not indicate delivery to Studio trunk.

AI assistance: GPT-6 Astra via OpenCode verified the source and regression-test inclusion and performed this requested PR consolidation.

@chubes4 chubes4 closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant