refactor(php-transformer): make font materialization plan-owned - #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues #1360: canonical site plans own nonempty
theme.font_materializationbefore identity calculation. Successful report and compact-view font fields project that canonical value, removing duplicate input derivation on the successful compilation path.Shipped report/view fields remain compatible. Failed results without a plan retain their report-only handoff. Old no-font plans remain valid without the additive field. Font-bearing plan identities intentionally change because font intent now participates in approval identity.
This is the BE producer portion only. SSI consumer migration is deferred pending its checkpoint work and a coordinated producer dependency update. No release or dependency/version mutation is included.
Validation
46fa2dc73fea185a57a92e543e2ca6961bbc2c20: Composer tests and WordPress integration across PHP 8.2-8.5, plus visual parity tools, and solved-site promotion.Reproduce from
php-transformerafter installing Composer dependencies:AI Assistance
AI-assisted implementation and independent review through OpenCode, coordinated by GPT-6 Astra under Chris Huber's direction. Delegated agents implemented and reviewed the change, and fresh lab verification was required before publication.