refactor(php-transformer): build site plans before report projection - #1656
Merged
Conversation
chubes4
marked this pull request as ready for review
September 10, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues #1360 by removing the provisional conversion report from artifact compilation. Internal site-plan construction consumes producer-owned fallback evidence, then the compiler constructs the terminal report once. Public
WordPressSitePlan::fromResult()retains strict canonical-envelope validation. Serialized source-report ordering is preserved.Verification
All ten CI checks passed on
242e71506f4f007754a73cab40462367a1ac6fdb: Composer tests, WordPress integration across PHP 8.2-8.5, and visual parity tools, plus solved-site promotion.git diff --checkpassed.FAIL [empty-plaintext-drops]; separate baseline and candidate runs reproduced the same failure in that environment. Final CI Composer suites passed across PHP 8.2-8.5 as linked above.Repo-native reproduction, from
php-transformerafter installing Composer dependencies:php tests/contract/wordpress-site-plan.php php tests/unit/text-leaf-element-converter.php composer test php tests/parity/run.phpAI Assistance
Implemented and reviewed with AI assistance through OpenCode, coordinated by GPT-6 Astra under Chris Huber's direction. Delegated agents handled implementation and independent review; the coordinator reviewed the diff and required fresh baseline/candidate evidence before publication.