Carry source button height constraints through native wrappers - #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Preserve source height constraints and selector specificity across core/buttons, core/button, and the rendered link. Includes variable-backed CSS math, minimum-height inheritance, responsive auto resets, and mixed-selector geometry projection without discarding non-button source rules.
Verified
Evidence And Remaining Gates
The earlier desktop failure is resolved: wrapper projection was erasing source specificity, allowing a later 10px minimum-height skin rule to win. The fix uses the existing specificity-preservation machinery rather than an arbitrary priority increase.
This remains draft pending review and CI. Whole-site parity is not claimed: form label-marker typography and row spacing still differ. The paired import included #1647 and Automattic/static-site-importer#1579; this PR isolates button-height work.
Reproduce
From php-transformer run
composer test. From php-transformer/tools/visual-parity runnpm ciandnpm testwith Playwright Chromium available. For full-site verification, package this candidate with the paired form work into an SSI development ZIP and use Studio PR #3952create --from https://www.busybearscleaning.com/ --keep-source --static-site-importer-path <zip>.AI assistance: OpenAI gpt-6-astra via OpenCode orchestrated diagnosis, corrected specificity projection, reviewed changes, and performed fresh Studio/browser verification. OpenAI gpt-5.6-terra via OpenCode implemented and tested the earlier isolated compiler candidates.