Use treegrid role for schema table#308
Closed
ahamelers wants to merge 1 commit into
Closed
Conversation
Member
|
There are too many changes to review here. Please split the changes into individual PRS and one PR should be submitted at a time. Multiple PRs will be rejected. In each PR include what exactly the problem is, why the current implementation is insufficient and what must change t support it your needs. I'm closing this PR as per the above and posting this same message on all other PRs. Please focus on one PR until that PR is approved and merge. We cannot support reviewing multiple PRs at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #305
The schema-table, which is tabular content with expandable rows, should use the ARIA treegrid roles and associated keyboard navigation. In addition to having the missing labels, aria-expanded, etc.