Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the admin user listing queries to improve performance on larger datasets, primarily by reducing expensive subquery patterns and pre-loading related membership data needed by the admin dashboard.
Changes:
- Eager-load platform/group memberships (and their platform/group objects) when querying users for admin endpoints.
- Replace several
IN (subquery)membership filters with correlatedEXISTSpredicates. - Add explicit
is_deleted = falsepredicates to membership subqueries.
Collaborator
|
Looks good to me, but please test extensively in dev/qa-ai |
uwwint
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With larger number of users some of our user queries are slow. Do some basic optimization to improve performance (e.g. including platform + group memberships when getting users for the user dashboard)