Add an API function to query for bitcom transaction ids.#77
Open
xloem wants to merge 5 commits intoAustEcon:masterfrom
Open
Add an API function to query for bitcom transaction ids.#77xloem wants to merge 5 commits intoAustEcon:masterfrom
xloem wants to merge 5 commits intoAustEcon:masterfrom
Conversation
…d adding support for API providers with differing features.
|
I'm not familiar with bitcom, but at first glance this looks pretty good. |
Doc fix from my mobile.
AustEcon
reviewed
Dec 12, 2020
| if planaria_token and network == 'main': | ||
| self.planaria = Planaria(token=planaria_token) | ||
| self.list_of_apis.append(self.planaria) | ||
|
|
Owner
There was a problem hiding this comment.
Oh ignore my earlier comment. I need to spend the time to actually test this code to understand it better than just reading it...
Sorry. I may have to come back to this next weekend...
What happens if PrivakeKey.get_bitcom_transactions() is called when there is no planaria token? does that case need to return a human-readable error that they require a token (or something like that)?
Contributor
Author
There was a problem hiding this comment.
I'm having some trouble replying to you here, I'm sorry. I tried to copy the way API keys were used in a pre-existing part of the system. I haven't verified the no-token case; the error may not be clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involved adding support for API providers with differing features.