Skip to content

Conversation

@rickyrombo
Copy link
Contributor

  • Removes old upload saga and references
  • Reverts tanstack query version to prevent error in production static builds, opting to copy/paste the mutateOptions method instead
  • Fix sparse arrays in progress for stems causing crash
  • Fix progress going backwards when there's stems
  • Fix error icon color to not be black

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: e516e5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rickyrombo rickyrombo review requested due to automatic review settings January 23, 2026 21:59
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks so dang good, nice work

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad

total: 0,
transcode: 0
}
const stems = newState.uploadProgress[trackIndex].stems
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so one stem update creates the progress for the others? wouldn't it be safer to just initialize this array in its entirety up front?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this works going forward is that progress starts reporting immediately after the "Select" page while the files upload in the background. But the users can select more stems on the next page. So before the user clicks "Confirm" there's already a progress report on their selected tracks but not for the art or stems - we need to then extend the initialized progress to include that.

To prevent this from showing progress going backwards, in the selector I check for the existence of the formState and use the formState's count of tracks/stems as the denominator. This prevents any race condition, as the formState gets set first before the stem upload progresses are fired off.

Rather than ensuring dense arrays, I could have also made the selector more defensive, but I think this is better.

@rickyrombo rickyrombo merged commit 203cec7 into mjp-tus-upload Jan 23, 2026
5 of 7 checks passed
@rickyrombo rickyrombo deleted the mjp-remove-upload-sagas branch January 23, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants