dls: Improve buffer address logging for debugging#57
Merged
quic-aditrath merged 1 commit intoAudioReach:masterfrom Apr 6, 2026
Merged
dls: Improve buffer address logging for debugging#57quic-aditrath merged 1 commit intoAudioReach:masterfrom
quic-aditrath merged 1 commit intoAudioReach:masterfrom
Conversation
Replace buffer pool start address with current buffer pointer address in DLS logging messages to provide more meaningful debugging information. The previous implementation logged the buffer pool's start address, which remained constant and provided limited diagnostic value. Update the log messages to display the actual buffer pointer addresses being used, making it easier to track individual buffer allocations and returns during debugging. Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
|
Would it be more useful to have both addresses? |
Contributor
Author
Buffer start address is already logged as part of DLS_PARAM_ID_CONFIG_BUFFER cmd in dls_set_param_config_buffer() (see: dls_set_param_config_buffer. Additionally, since buffer acquire and release are frequent operations, do we really need to log them again, or would this be redundant with the existing logs? |
|
I think what you have works better. We can continue with that approach |
essi-kode
approved these changes
Mar 27, 2026
quic-plai
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace buffer pool start address with current buffer pointer address in DLS logging messages to provide more meaningful debugging information.
The previous implementation logged the buffer pool's start address, which remained constant and provided limited diagnostic value. Update the log messages to display the actual buffer pointer addresses being used, making it easier to track individual buffer allocations and returns during debugging.