Skip to content

onclose callback not called when connection close by timeout #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperPat45 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

onclose callback not called when connection close by timeout #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/javascript/src/main/webapp/javascript/atmosphere.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,6 +1568,8 @@
atmosphere.util.warn("Websocket closed, reason: " + reason + ' - wasClean: ' + message.wasClean);
}

_invokeClose(webSocketOpened);

if (_response.closedByClientTimeout || (_request.handleOnlineOffline && offline)) {
// IFF online/offline events are handled and we happen to be offline, we stop all reconnect attempts and
// resume them in the "online" event (if we get here in that case, something else went wrong as the
Expand All @@ -1582,8 +1584,6 @@
return;
}

_invokeClose(webSocketOpened);

_response.state = 'closed';

if (_abortingConnection) {
Expand Down