chore: move pnpm overrides to pnpm-workspace.yaml - #9391
Open
shentry wants to merge 1 commit into
Open
Conversation
The `immutable` and `lodash-es` dependency pins lived in the deprecated `pnpm.overrides` field of dashboard/package.json. pnpm 10 reads project settings from pnpm-workspace.yaml, so keep the pins alongside the existing `allowBuilds` settings to make sure they keep applying on future pnpm releases. Verified with the CI-pinned pnpm 10.28.2: `pnpm install --frozen-lockfile` succeeds, pnpm-lock.yaml is byte-identical to before the move (its `overrides` block is preserved), `pnpm run build` passes, and the installed tree still resolves immutable@4.3.8 and lodash-es@4.17.23. Closes AstrBotDevs#8601
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
dosubot
Bot
added
size:XS
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8601
Change
Move the
immutableandlodash-espins from the deprecatedpnpm.overridesfield indashboard/package.jsonintodashboard/pnpm-workspace.yaml, alongside theallowBuildssettings that already live there.A note on the issue's premise
The issue's first acceptance criterion says pnpm prints a warning that
package.json'spnpm.overridesis ignored. I was not able to reproduce that. With both the CI-pinned pnpm 10.28.2 and pnpm 10.33.2, no such warning is printed and the overrides are currently fully effective: removing thepnpmblock without adding it topnpm-workspace.yamlmakes the lockfile drop itsoverrides:section andlodash-esfall back from 4.17.23 to 4.17.21.So this PR is not repairing broken pins. It is a forward-looking migration to the location pnpm 10+ expects, so the pins keep applying on future pnpm releases. Happy to close it if you would rather leave the pins where they are for now.
Verification
All with the CI-pinned pnpm 10.28.2:
pnpm install --frozen-lockfilesucceedspnpm-lock.yamlis byte-identical to before the move and itsoverrides:block is preserved, so the lockfile is untouched in this PRpnpm run buildpassesimmutable@4.3.8andlodash-es@4.17.23Summary by Sourcery
Move pnpm dependency override configuration from the dashboard package.json into the pnpm-workspace.yaml to align with current pnpm expectations while preserving existing pins.
Build:
Chores: