chore: reduce pyright type errors#8197
Open
Dt8333 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
first_text, consider narrowing theexcept Exceptionaroundint(exit_code)toexcept (TypeError, ValueError)so that unexpected errors inexit_codehandling are not silently swallowed. - The
task.add_done_callbacklambda in the DingTalk adapter relies on the mutableself._shutdown_eventattribute; it might be clearer and safer to capture the event in a local variable (or a small helper function) before defining the callback to avoid potential races if the attribute is reassigned.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `first_text`, consider narrowing the `except Exception` around `int(exit_code)` to `except (TypeError, ValueError)` so that unexpected errors in `exit_code` handling are not silently swallowed.
- The `task.add_done_callback` lambda in the DingTalk adapter relies on the mutable `self._shutdown_event` attribute; it might be clearer and safer to capture the event in a local variable (or a small helper function) before defining the callback to avoid potential races if the attribute is reassigned.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several refactorings and robustness improvements across the codebase. Key changes include safer attribute access and type casting in the CUA booter, updated SQLAlchemy query syntax using col() for column references, and refined type hints for MCP clients and tool registries. Additionally, the PR adds safety checks for event callbacks in the DingTalk adapter and streamlines logic in the Anthropic provider and plugin updater. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce Pyright type-checking errors.
Modifications / 改动点
Adjusted the execution order of certain sections and added conditional checks to allow Pyright to correctly narrow types.
Corrected several declarations.
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Improve type safety and static analysis compliance across core components to reduce Pyright errors.
Bug Fixes:
Enhancements: