feat: add confirmation dialog for update all plugins button to preven… #4658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我在这里给了一些总体反馈：
- 建议将新的
updateAllConfirmDialog状态和处理函数与现有对话框模式（例如forceUpdateDialog及其确认/取消方法）对齐，这样可以保持对话框管理的一致性并让维护更容易。 - 目前
confirmUpdateAll即使在对话框打开期间updatableExtensions变为空时，仍然会触发updateAllExtensions()；如果这不是你期望的行为，你可能需要在这里重新检查一次updatableExtensions.length，并在为空时不执行任何操作（no-op）或相应地关闭对话框。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- Consider aligning the new `updateAllConfirmDialog` state and handlers with the existing dialog patterns (e.g., `forceUpdateDialog` and its confirm/cancel methods) to keep dialog management consistent and easier to maintain.
- Right now `confirmUpdateAll` will trigger `updateAllExtensions()` even if `updatableExtensions` becomes empty while the dialog is open; if that’s not desired, you might want to re-check `updatableExtensions.length` there and no-op or close the dialog accordingly.帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- Consider aligning the new
updateAllConfirmDialogstate and handlers with the existing dialog patterns (e.g.,forceUpdateDialogand its confirm/cancel methods) to keep dialog management consistent and easier to maintain. - Right now
confirmUpdateAllwill triggerupdateAllExtensions()even ifupdatableExtensionsbecomes empty while the dialog is open; if that’s not desired, you might want to re-checkupdatableExtensions.lengththere and no-op or close the dialog accordingly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider aligning the new `updateAllConfirmDialog` state and handlers with the existing dialog patterns (e.g., `forceUpdateDialog` and its confirm/cancel methods) to keep dialog management consistent and easier to maintain.
- Right now `confirmUpdateAll` will trigger `updateAllExtensions()` even if `updatableExtensions` becomes empty while the dialog is open; if that’s not desired, you might want to re-check `updatableExtensions.length` there and no-op or close the dialog accordingly.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
dosubot
bot
added
the
area:webui
tooplick
force-pushed
the
feature/update-all-confirmation
branch
from
7c5ee06 to
e033eed
Compare
Contributor
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - 我发现了 1 个问题，并给出了一些总体反馈：
- 在
ExtensionPage.vue中updateAllConfirmDialog的使用以及对应对话框模板附近存在未解决的合并冲突标记（<<<<<<<,=======,>>>>>>>），需要在合并前清理。 updateAllConfirmDialog的状态结构应与其他对话框保持一致（例如forceUpdateDialog.show），并在脚本和模板中统一使用，而不是混用.show和直接v-model="updateAllConfirmDialog"的模式。- 在
confirmUpdateAll中，你已经在继续处理之前重新检查了updatableExtensions.length；建议将这个防护逻辑集中放在updateAllExtensions()本身中，这样未来其他调用方也能受益于这个安全检查。
给 AI Agent 的提示
请根据这次代码评审中的评论进行修改：
## 总体评论
- 在 `ExtensionPage.vue` 中 `updateAllConfirmDialog` 的使用以及对应对话框模板附近存在未解决的合并冲突标记（`<<<<<<<`, `=======`, `>>>>>>>`），需要在合并前清理。
- `updateAllConfirmDialog` 的状态结构应与其他对话框保持一致（例如 `forceUpdateDialog.show`），并在脚本和模板中统一使用，而不是混用 `.show` 和直接 `v-model="updateAllConfirmDialog"` 的模式。
- 在 `confirmUpdateAll` 中，你已经在继续处理之前重新检查了 `updatableExtensions.length`；建议将这个防护逻辑集中放在 `updateAllExtensions()` 本身中，这样未来其他调用方也能受益于这个安全检查。
## 逐条评论
### 评论 1
<location> `dashboard/src/views/ExtensionPage.vue:482-486` </location>
<code_context>
+// 显示更新全部插件确认对话框
+const showUpdateAllConfirm = () => {
+ if (updatableExtensions.value.length === 0) return;
+<<<<<<< HEAD
+ updateAllConfirmDialog.show = true;
+=======
+ updateAllConfirmDialog.value = true;
+>>>>>>> 7c5ee0641efeadd82812eaae2086d72f470ac690
+};
+
</code_context>
<issue_to_address>
**issue (bug_risk):** 需要解决 `showUpdateAllConfirm` / `confirmUpdateAll` 代码块中的未解决合并冲突标记。
这些冲突标记会导致代码无法编译。请选择 `updateAllConfirmDialog.show` 或 `updateAllConfirmDialog.value` 其中之一作为正确实现，移除另一个，并删除所有 `<<<<<<<`、`=======` 和 `>>>>>>>` 行。
</issue_to_address>帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've found 1 issue, and left some high level feedback:
- There are unresolved merge conflict markers (
<<<<<<<,=======,>>>>>>>) inExtensionPage.vuearoundupdateAllConfirmDialogusage and the dialog template that need to be cleaned up before merging. - The state shape for
updateAllConfirmDialogshould be made consistent with other dialogs (e.g.,forceUpdateDialog.show) and used uniformly in both script and template, instead of mixing.showand directv-model="updateAllConfirmDialog"patterns. - In
confirmUpdateAll, you already re-checkupdatableExtensions.lengthbefore proceeding; consider centralizing this guard inupdateAllExtensions()itself so future callers also benefit from the safety check.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are unresolved merge conflict markers (`<<<<<<<`, `=======`, `>>>>>>>`) in `ExtensionPage.vue` around `updateAllConfirmDialog` usage and the dialog template that need to be cleaned up before merging.
- The state shape for `updateAllConfirmDialog` should be made consistent with other dialogs (e.g., `forceUpdateDialog.show`) and used uniformly in both script and template, instead of mixing `.show` and direct `v-model="updateAllConfirmDialog"` patterns.
- In `confirmUpdateAll`, you already re-check `updatableExtensions.length` before proceeding; consider centralizing this guard in `updateAllExtensions()` itself so future callers also benefit from the safety check.
## Individual Comments
### Comment 1
<location> `dashboard/src/views/ExtensionPage.vue:482-486` </location>
<code_context>
+// 显示更新全部插件确认对话框
+const showUpdateAllConfirm = () => {
+ if (updatableExtensions.value.length === 0) return;
+<<<<<<< HEAD
+ updateAllConfirmDialog.show = true;
+=======
+ updateAllConfirmDialog.value = true;
+>>>>>>> 7c5ee0641efeadd82812eaae2086d72f470ac690
+};
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Unresolved merge conflict markers need to be resolved in the `showUpdateAllConfirm` / `confirmUpdateAll` block.
These conflict markers will prevent the code from compiling. Please choose either `updateAllConfirmDialog.show` or `updateAllConfirmDialog.value` as the correct implementation, remove the other, and delete all `<<<<<<<`, `=======`, and `>>>>>>>` lines.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tooplick
force-pushed
the
feature/update-all-confirmation
branch
from
234d1b6 to
9832e5e
Compare
Contributor
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈：
- 可以考虑复用或抽象出一个已有的通用确认对话框模式（如果你在其他破坏性操作，比如卸载/强制更新，已经有类似的模式），这样“全部更新”的确认对话框就能保持一致，并避免重复实现对话框逻辑。
- 当
confirmUpdateAll触发updateAllExtensions时，你可能还需要把updatingAll状态也接入到对话框按钮中（例如：禁用按钮/显示加载中），这样在更新已经进行中的情况下，用户就无法通过确认对话框再次触发批量更新。
给 AI Agents 的提示
Please address the comments from this code review:
## Overall Comments
- Consider reusing or abstracting an existing generic confirmation dialog pattern (if you have one for other destructive actions like uninstall/force-update) so the update-all confirmation stays consistent and avoids duplicating dialog logic.
- When `confirmUpdateAll` triggers `updateAllExtensions`, you might want to wire the `updatingAll` state into the dialog buttons as well (e.g., disable/ show loading), so users can’t double-trigger the bulk update from the confirmation dialog while an update is already in progress.帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈来改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- Consider reusing or abstracting an existing generic confirmation dialog pattern (if you have one for other destructive actions like uninstall/force-update) so the update-all confirmation stays consistent and avoids duplicating dialog logic.
- When
confirmUpdateAlltriggersupdateAllExtensions, you might want to wire theupdatingAllstate into the dialog buttons as well (e.g., disable/ show loading), so users can’t double-trigger the bulk update from the confirmation dialog while an update is already in progress.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider reusing or abstracting an existing generic confirmation dialog pattern (if you have one for other destructive actions like uninstall/force-update) so the update-all confirmation stays consistent and avoids duplicating dialog logic.
- When `confirmUpdateAll` triggers `updateAllExtensions`, you might want to wire the `updatingAll` state into the dialog buttons as well (e.g., disable/ show loading), so users can’t double-trigger the bulk update from the confirmation dialog while an update is already in progress.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
我觉得可以不用管这个Sourcery AI了，很小的改动 |
Soulter
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t accidental clicks #4300
修复了issue #4300 添加了更新所有插件二次确认
Modifications / 改动点
dashboard/src/views/ExtensionPage.vue: 添加确认对话框变量、方法和模板，修改按钮点击事件
dashboard/src/i18n/locales/zh-CN/features/extension.json: 添加中文国际化文本
dashboard/src/i18n/locales/en-US/features/extension.json: 添加英文国际化文本
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
点击"更新全部插件"按钮后弹出确认对话框，可选择取消或确认更新。
Checklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.Summary by Sourcery
在扩展仪表盘中，在触发“更新所有插件”操作之前添加确认对话框。
新功能:
增强改进:
Original summary in English
Summary by Sourcery
Add a confirmation dialog before triggering the "update all plugins" action on the extensions dashboard.
New Features:
Enhancements:
Summary by Sourcery
在扩展页触发「更新所有插件」操作前新增确认流程，以防止意外批量更新。
新功能：
增强优化：
Original summary in English
Summary by Sourcery
Add a confirmation flow before triggering the "update all plugins" action on the extensions page to prevent accidental bulk updates.
New Features:
Enhancements:
Original summary in English
Summary by Sourcery
在扩展页触发「更新所有插件」操作前新增确认流程，以防止意外批量更新。
新功能：
增强优化：
Original summary in English
Summary by Sourcery
Add a confirmation flow before triggering the "update all plugins" action on the extensions page to prevent accidental bulk updates.
New Features:
Enhancements: