test: mock plugin market requests in dashboard tests - #10062
Open
lingyun14beta wants to merge 1 commit into
Open
test: mock plugin market requests in dashboard tests#10062lingyun14beta wants to merge 1 commit into
lingyun14beta wants to merge 1 commit into
Conversation
tests/test_dashboard.py::test_plugins hit the live plugin marketplace, so its result depended on whether the runner could reach api.soulter.top. Mock the aiohttp session used by PluginService so the case runs deterministically offline, and assert the market payload actually reaches the API response. Refs AstrBotDevs#10058
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
kilisamemarisaaa
approved these changes
Sep 12, 2026
kilisamemarisaaa
left a comment
kilisamemarisaaa
left a comment
There was a problem hiding this comment.
Verified at b024f86. The fake session matches the async context-manager/get/json protocol used by both the market fetch and MD5 check, and the fixture-key assertion confirms the endpoint returns the supplied data instead of merely returning HTTP 200.
Independent local validation on Windows:
- Targeted test_plugins: 1 passed.
- Repeated with a temporary test-scoped guard rejecting non-loopback socket connect/connect_ex and DNS resolution, with a teardown assertion to catch swallowed attempts: 1 passed, zero recorded external attempts.
- Same guard against base 7ec39bd: the test fails and records an api.soulter.top attempt, confirming the guard exercises the original problem.
- Ruff check and format --check for tests/test_dashboard.py: passed.
This validation is specifically for test_plugins, not a claim that the entire test suite is network-independent. No blocking findings in this scoped change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #10058
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Mock plugin market network calls in dashboard tests to ensure reliable, self-contained test results.
Bug Fixes:
Tests: