feat: support PPTX uploads in knowledge base - #10039
Open
wutongyuonce wants to merge 1 commit into
Open
Conversation
Route .pptx through MarkItDown, chunk as Markdown, and expose the format in the dashboard picker. Keep legacy .ppt rejected as an unsupported format.
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If PPTX parsing is wrong, the resulting text and embeddings can be written to the knowledge base and produce incorrect search results after the revert. The affected documents and derived records are bounded and can be deleted or reprocessed, so the damage is repairable rather than permanent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10038
Knowledge base already parses Office files through MarkItDown (
docx/xls/xlsx), but.pptxwas not routed, not in the Markdown chunker whitelist, and not listed in the dashboard upload picker. This follows the existing Office path instead of adding a new parser.Modifications / 改动点
Route
.pptxtoMarkitdownParserand enable thepptxextra ofmarkitdown-no-magika.Chunk PPTX text with
MarkdownChunker, same asdocx.Surface
暂时不支持的文件格式fromselect_parserinstead of wrapping it as a corrupt-file parse error (legacy.pptstays unsupported).Add
.pptxto the dashboard accept list, file icons, and zh/en/ja/ru copy.Tests: parser routing, slide-text extraction, Markdown chunker whitelist, and
.pptrejection.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Independent Codex review (read-only): no blocking issues. Checks also included
uv lock --check, locale JSON parse, andgit diff --check.Checklist / 检查清单
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。/ 我的更改没有引入恶意代码。
Summary by Sourcery
Support PPTX knowledge-base uploads while retaining clear rejection behavior for unsupported legacy PPT files.
New Features:
Bug Fixes:
Enhancements:
Build:
Tests: