Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While dragging a selection, every mouse move repainted the whole control, even when the selection didn't change at all, which is the case for most moves within the same character.
SelectionHandlernow only invalidates when the selection start or end word, or the character index within them, changed.This doesn't explain the flicker in #271 on its own, the video shows half-painted frames, which points to the control painting without its back buffer. But fewer full repaints means a lot less traffic and flicker over remote desktop, especially for
<pre>content, where every preserved space is its own word to draw.See #271
How to test this PR?
CI should succeed.
SelectionInvalidateIntegrationTestschecks the repaint count and fails on master.