Repository navigation
Update Vortex to 2.10.0 and ship .deb and .rpm packages - #34
Merged
Merged
Conversation
Vortex reports a missing .NET in its window, so grepping stdout for it never failed.
One script now builds the .deb and the .rpm from the same staged tree, and the smoke test installs either with apt, dnf or zypper.
The self-test now runs without a display: Wine 11 stalls creating a prefix under Xvfb.
All artifacts are tested in one matrix job, and the release upload takes every downloaded file.
A minimal openSUSE has no fonts, and Vortex then shows an empty window.
Vortex 2.10.0 has its own getVolumePath and moved the game stores to native promises, so 0003 and 0009 shrink and the Heroic, Lutris and Bottles stores follow. Its new backup and manifest code reads deployment paths with node:fs directly; 0029 maps them into the Wine prefix and records turbowalk's Linux mtimes in milliseconds.
The Games page Vortex 2.10 opens on renders id="page-<id>" instead of .main-page-inner, so every package smoke test timed out. A page that failed to render no longer counts as ready.
Xvfb, D-Bus and Python came in the same transaction as the package and could hide a missing dependency from the ldd check.
The dependency listed ICU 74 to 80, so a published package would stop installing once a distribution moves to ICU 81. .NET loads newer ICU itself.
Importing a file changed outside Vortex copied it through .vortex-import in the staging folder and never removed it, so Vortex offered it as a new mod.
The AppImage and the packages set DOTNET_ROOT for Vortex itself, and a Windows .NET program started through Wine looks there for hostfxr.dll.
Manifests from earlier Linux builds hold times a thousand times too large, which Vortex 2.10 reads as replaced files. A backup named in another case was overwritten instead of stopping the deployment.
The Witcher 3 extension writes mods.settings through vortex-api's fs and then renames it with node:fs/promises, so the file landed in the prefix while the rename looked for it on the host.
Removed the 'Games tested (confirmed working)' section from the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vortex 2.10.0 broke patch 0002 in the nightly update (#33). This ports all 40 patches to 2.10.0 and brings in the
deb-packagebranch, so 2.10.0-1 is the first release with a.deband an.rpm.Port:
node:fsdirectly, so config files deployed into a Proton prefix lost their.vortex_backup. 0029 maps those paths into the prefix again and records deployment times correctly on Linux.After review:
id="page-…"); every package test timed out on it before..vortex-importin staging, where Vortex saw it as a new mod.DOTNET_ROOTpointing at the Linux .NET runtime.Also:
fsdirectly find files in Documents and AppData where vortex-api's fs puts them, in the game's prefix. The Witcher 3 couldn't savemods.settingsbecause of this.Fixes #33