Repository navigation
Conversation
Normalize datetime and ISO string input before dedup; reject invalid deadlines. 46 SQLite store tests passed; scoped Ruff passed. Existing non-UTC database rows are intentionally not migrated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owned-client shutdown — 2026-10-30
Current head
f938dd09510ecbd16fd62ca8428adb2401785b69additionally closes the feed HTTP and transcription clients created bybuild_runtime. These were previously omitted from normal shutdown. An exit stack also closes these resources and SQLite if scheduler/summarizer cleanup raises.Two new offline tests fail before the fix and pass afterwards (normal close and a failing summarizer close). Full local suite: 247 tests passed, one dependency deprecation warning; full Ruff and diff checks passed. No requests to model or feed endpoints. Local/published tree:
01a9a7b2b677f4d0b2a63f679bfdeb68fc3462b3. All six exact-head CI checks passed: run 40979177883, verified 2026-10-30 00:24 UTC. Construction-time failures and concurrent close remain outside this fix.Normal-shutdown recovery — 2026-10-30
Previous head
67c186f1e17bb762b22c62fa23fc5015a8a325d8records interrupted jobs before the runtime closes SQLite. Previously normal shutdown left freshly claimed jobsrunning; a restart within 30 minutes skipped them and the startup-only stale recovery never revisited them.tests/v2suite passed (245 cases, one dependency deprecation warning); fullruff check vra testsandgit diff --checkpassed. Tests use SQLite and fake services, not model APIs or user devices.3a04a9f55c385681ce2c704a81c1d714f7485163matches the published tree. Remote CI for this exact head passed all six Linux/macOS/Windows × Python 3.11/3.12 checks: run 40978686135, verified 2026-10-30 00:18 UTC. Older-head CI remains historical.Stacked on #2. New source:v2 SHA-256 keys preserve query/order/encoding/path case; feed GUID remains metadata. Feed and API share this identity and default non-force queue payload, preventing separate jobs for one new source.
Legacy rows, UUIDs, artifacts and jobs are preserved without schema version changes. They are not automatically adopted: old lossy hashes could have overwritten source_url while retaining another video's completed summary. New ingestion may create a duplicate historical RSS entry; explicit legacy video_id processing remains available. This does not silently repair historical ambiguity.
Historical source-identity validation: 229 tests and Ruff passed locally. Coverage includes distinct watch?v=A/B, reused GUID, conservative URL distinctions, feed/API order permutations through real SQLite + ASGI transport, default-job dedup and legacy summary/job preservation. No database migration/reset, inference, downloads, deployment or merge. That earlier CI result does not validate the current head.