Fixed issue with mismatched test names for the arabic and hebrew trans pdf samples#215
Merged
bcldemjen merged 1 commit intoJun 18, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands beyond the stated goal of renaming mismatched Arabic/Hebrew TransPDF test names by also adding new TransPDF sample tests/assets, introducing Go Layout (FlowDocument/ContentTree) bindings plus a new Go DocumentCreation sample, and updating CI pipelines/artifact paths.
Changes:
- Added dedicated TransPDF Arabic/Hebrew sample tests across Ruby/Python/PHP/Go, plus corresponding XLIFF test assets.
- Added Go Layout bindings (FlowDocument/ContentTree) and a new Go DocumentCreation sample; updated SWIG/CMake glue to support ElementRef semantics.
- Updated multiple Jenkins Go pipelines (artifact source paths/credentials) and adjusted Alpine Go sample execution.
Reviewed changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/TransPDFTest/RUBY/TransPDFTest.rb | Adds commented guidance for running XLIFF 2 sample input. |
| Samples/TransPDFTest/PYTHON/TransPDFTest.py | Adds commented guidance for running XLIFF 2 sample input. |
| Samples/TransPDFTest/PHP/TransPDFTest.php | Adds commented guidance for running XLIFF 2 sample input. |
| Samples/TransPDFTest/GO/TransPDF_test.go | Adds commented guidance for running XLIFF 2 sample input. |
| Samples/TransPDFHebrewTest/RUBY/TransPDFHebrewTest.rb | New Hebrew TransPDF sample test (Ruby). |
| Samples/TransPDFHebrewTest/RUBY/RunTest.sh | New Ruby runner script for Hebrew TransPDF sample. |
| Samples/TransPDFHebrewTest/RUBY/RunTest.bat | New Windows Ruby runner script for Hebrew TransPDF sample. |
| Samples/TransPDFHebrewTest/PYTHON/TransPDFHebrewTest.py | New Hebrew TransPDF sample test (Python). |
| Samples/TransPDFHebrewTest/PHP/TransPDFHebrewTest.php | New Hebrew TransPDF sample test (PHP). |
| Samples/TransPDFHebrewTest/PHP/RunTest.sh | New PHP runner script for Hebrew TransPDF sample. |
| Samples/TransPDFHebrewTest/PHP/RunTest.bat | New Windows PHP runner script for Hebrew TransPDF sample. |
| Samples/TransPDFHebrewTest/GO/TransPDFHebrew_test.go | New Hebrew TransPDF sample test (Go). |
| Samples/TransPDFArabicTest/RUBY/TransPDFArabicTest.rb | New Arabic TransPDF sample test (Ruby). |
| Samples/TransPDFArabicTest/RUBY/RunTest.sh | New Ruby runner script for Arabic TransPDF sample. |
| Samples/TransPDFArabicTest/RUBY/RunTest.bat | New Windows Ruby runner script for Arabic TransPDF sample. |
| Samples/TransPDFArabicTest/PYTHON/TransPDFArabicTest.py | New Arabic TransPDF sample test (Python). |
| Samples/TransPDFArabicTest/PHP/TransPDFArabicTest.php | New Arabic TransPDF sample test (PHP). |
| Samples/TransPDFArabicTest/PHP/RunTest.sh | New PHP runner script for Arabic TransPDF sample. |
| Samples/TransPDFArabicTest/PHP/RunTest.bat | New Windows PHP runner script for Arabic TransPDF sample. |
| Samples/TransPDFArabicTest/GO/TransPDFArabic_test.go | New Arabic TransPDF sample test (Go). |
| Samples/TestFiles/translation-test-(en_to_he).xlf | Adds Hebrew translation XLIFF test asset. |
| Samples/TestFiles/translation-test-(en_to_ar).xlf | Adds Arabic translation XLIFF test asset. |
| Samples/TestFiles/find-replace-test_(en_to_fr)-2.xlf | Adds XLIFF 2 version of the find/replace translation test asset. |
| Samples/HandwritingICRTest/RUBY/HandwritingICRTest.rb | Comments out Example 2 and changes ignore-zone page logic. |
| Samples/HandwritingICRTest/PYTHON/HandwritingICRTest.py | Comments out Example 2 and changes ignore-zone page logic. |
| Samples/HandwritingICRTest/PHP/HandwritingICRTest.php | Comments out Example 2 and changes ignore-zone page logic. |
| Samples/HandwritingICRTest/GO/HandwritingICR_test.go | Comments out Example 2 and changes ignore-zone page logic. |
| Samples/DocumentCreationTest/GO/DocumentCreation_test.go | New Go DocumentCreation sample using FlowDocument/ContentTree APIs. |
| PDFTronGo/pdftron.i | Adds Layout headers, ElementRef goout typemap, iterator template, and valuewrapper feature. |
| PDFTronGo/CMakeLists.txt | Adds SWIG-generated Go post-processing step for ElementRef types. |
| PDFNetPython/PDFNetPython.i | Adds valuewrapper feature for PDFDoc. |
| PDFNetPHP/PDFNetPHP.i | Adds valuewrapper feature for PDFDoc. |
| jenkinsfiles/build_win_go.groovy | Updates S3 artifact source path for Windows Go builds. |
| jenkinsfiles/build_mac_go.groovy | Updates S3 artifact source path for macOS Go builds. |
| jenkinsfiles/build_mac_arm_go.groovy | Updates S3 artifact source path for macOS ARM Go builds. |
| jenkinsfiles/build_linux_go.groovy | Updates docker registry credentials ID and S3 artifact source path for Linux Go builds. |
| jenkinsfiles/build_linux_arm_go.groovy | Updates docker registry credentials ID and S3 artifact source path for Linux ARM Go builds. |
| jenkinsfiles/build_alpine_go.groovy | Updates docker registry credentials ID, S3 artifact source path, and skips TransPDF Go samples on Alpine. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rchennafi
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renamed incorrect Arabic and Hebrew test names for TransPDF tests.
Context/Why?
See above.
Implementation notes
Changed occurrences of sample file names and files of
TransPDFTestArabicandTransPDFTestHebrewtoTransPDFArabicTestandTransPDFHebrewTestrespectively.How to verify
Check the PDFNetWrapper TransPDF tests for Arabic and Hebrew work correctly.
Changelog entry
N/A