Skip to content

Fixed issue with mismatched test names for the arabic and hebrew trans pdf samples#215

Merged
bcldemjen merged 1 commit into
next_releasefrom
Fixed-issue-with-mismatched-test-names-for-the-Arabic-and-Hebrew-TransPDF-samples
Jun 18, 2026
Merged

Fixed issue with mismatched test names for the arabic and hebrew trans pdf samples#215
bcldemjen merged 1 commit into
next_releasefrom
Fixed-issue-with-mismatched-test-names-for-the-Arabic-and-Hebrew-TransPDF-samples

Conversation

@mrmartinclark

Copy link
Copy Markdown
Contributor

Summary

Renamed incorrect Arabic and Hebrew test names for TransPDF tests.

Context/Why?

See above.

Implementation notes

Changed occurrences of sample file names and files of TransPDFTestArabic and TransPDFTestHebrew to TransPDFArabicTest and TransPDFHebrewTest respectively.

How to verify

Check the PDFNetWrapper TransPDF tests for Arabic and Hebrew work correctly.

Changelog entry

N/A

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands beyond the stated goal of renaming mismatched Arabic/Hebrew TransPDF test names by also adding new TransPDF sample tests/assets, introducing Go Layout (FlowDocument/ContentTree) bindings plus a new Go DocumentCreation sample, and updating CI pipelines/artifact paths.

Changes:

  • Added dedicated TransPDF Arabic/Hebrew sample tests across Ruby/Python/PHP/Go, plus corresponding XLIFF test assets.
  • Added Go Layout bindings (FlowDocument/ContentTree) and a new Go DocumentCreation sample; updated SWIG/CMake glue to support ElementRef semantics.
  • Updated multiple Jenkins Go pipelines (artifact source paths/credentials) and adjusted Alpine Go sample execution.

Reviewed changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
Samples/TransPDFTest/RUBY/TransPDFTest.rb Adds commented guidance for running XLIFF 2 sample input.
Samples/TransPDFTest/PYTHON/TransPDFTest.py Adds commented guidance for running XLIFF 2 sample input.
Samples/TransPDFTest/PHP/TransPDFTest.php Adds commented guidance for running XLIFF 2 sample input.
Samples/TransPDFTest/GO/TransPDF_test.go Adds commented guidance for running XLIFF 2 sample input.
Samples/TransPDFHebrewTest/RUBY/TransPDFHebrewTest.rb New Hebrew TransPDF sample test (Ruby).
Samples/TransPDFHebrewTest/RUBY/RunTest.sh New Ruby runner script for Hebrew TransPDF sample.
Samples/TransPDFHebrewTest/RUBY/RunTest.bat New Windows Ruby runner script for Hebrew TransPDF sample.
Samples/TransPDFHebrewTest/PYTHON/TransPDFHebrewTest.py New Hebrew TransPDF sample test (Python).
Samples/TransPDFHebrewTest/PHP/TransPDFHebrewTest.php New Hebrew TransPDF sample test (PHP).
Samples/TransPDFHebrewTest/PHP/RunTest.sh New PHP runner script for Hebrew TransPDF sample.
Samples/TransPDFHebrewTest/PHP/RunTest.bat New Windows PHP runner script for Hebrew TransPDF sample.
Samples/TransPDFHebrewTest/GO/TransPDFHebrew_test.go New Hebrew TransPDF sample test (Go).
Samples/TransPDFArabicTest/RUBY/TransPDFArabicTest.rb New Arabic TransPDF sample test (Ruby).
Samples/TransPDFArabicTest/RUBY/RunTest.sh New Ruby runner script for Arabic TransPDF sample.
Samples/TransPDFArabicTest/RUBY/RunTest.bat New Windows Ruby runner script for Arabic TransPDF sample.
Samples/TransPDFArabicTest/PYTHON/TransPDFArabicTest.py New Arabic TransPDF sample test (Python).
Samples/TransPDFArabicTest/PHP/TransPDFArabicTest.php New Arabic TransPDF sample test (PHP).
Samples/TransPDFArabicTest/PHP/RunTest.sh New PHP runner script for Arabic TransPDF sample.
Samples/TransPDFArabicTest/PHP/RunTest.bat New Windows PHP runner script for Arabic TransPDF sample.
Samples/TransPDFArabicTest/GO/TransPDFArabic_test.go New Arabic TransPDF sample test (Go).
Samples/TestFiles/translation-test-(en_to_he).xlf Adds Hebrew translation XLIFF test asset.
Samples/TestFiles/translation-test-(en_to_ar).xlf Adds Arabic translation XLIFF test asset.
Samples/TestFiles/find-replace-test_(en_to_fr)-2.xlf Adds XLIFF 2 version of the find/replace translation test asset.
Samples/HandwritingICRTest/RUBY/HandwritingICRTest.rb Comments out Example 2 and changes ignore-zone page logic.
Samples/HandwritingICRTest/PYTHON/HandwritingICRTest.py Comments out Example 2 and changes ignore-zone page logic.
Samples/HandwritingICRTest/PHP/HandwritingICRTest.php Comments out Example 2 and changes ignore-zone page logic.
Samples/HandwritingICRTest/GO/HandwritingICR_test.go Comments out Example 2 and changes ignore-zone page logic.
Samples/DocumentCreationTest/GO/DocumentCreation_test.go New Go DocumentCreation sample using FlowDocument/ContentTree APIs.
PDFTronGo/pdftron.i Adds Layout headers, ElementRef goout typemap, iterator template, and valuewrapper feature.
PDFTronGo/CMakeLists.txt Adds SWIG-generated Go post-processing step for ElementRef types.
PDFNetPython/PDFNetPython.i Adds valuewrapper feature for PDFDoc.
PDFNetPHP/PDFNetPHP.i Adds valuewrapper feature for PDFDoc.
jenkinsfiles/build_win_go.groovy Updates S3 artifact source path for Windows Go builds.
jenkinsfiles/build_mac_go.groovy Updates S3 artifact source path for macOS Go builds.
jenkinsfiles/build_mac_arm_go.groovy Updates S3 artifact source path for macOS ARM Go builds.
jenkinsfiles/build_linux_go.groovy Updates docker registry credentials ID and S3 artifact source path for Linux Go builds.
jenkinsfiles/build_linux_arm_go.groovy Updates docker registry credentials ID and S3 artifact source path for Linux ARM Go builds.
jenkinsfiles/build_alpine_go.groovy Updates docker registry credentials ID, S3 artifact source path, and skips TransPDF Go samples on Alpine.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PDFTronGo/CMakeLists.txt
Comment thread Samples/HandwritingICRTest/RUBY/HandwritingICRTest.rb
Comment thread Samples/HandwritingICRTest/PYTHON/HandwritingICRTest.py
Comment thread Samples/HandwritingICRTest/PHP/HandwritingICRTest.php
Comment thread Samples/HandwritingICRTest/GO/HandwritingICR_test.go
Comment thread Samples/DocumentCreationTest/GO/DocumentCreation_test.go
Comment thread Samples/DocumentCreationTest/GO/DocumentCreation_test.go
Comment thread jenkinsfiles/build_alpine_go.groovy
@mrmartinclark mrmartinclark changed the base branch from master to next_release June 18, 2026 14:22

@investintech-alish investintech-alish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bcldemjen bcldemjen merged commit 1dca49a into next_release Jun 18, 2026
1 check passed
@bcldemjen bcldemjen deleted the Fixed-issue-with-mismatched-test-names-for-the-Arabic-and-Hebrew-TransPDF-samples branch June 18, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants