Improve key quantization and add command length#19
Open
zachmccormick wants to merge 3 commits intodeployed-in-platformfrom
Open
Improve key quantization and add command length#19zachmccormick wants to merge 3 commits intodeployed-in-platformfrom
zachmccormick wants to merge 3 commits intodeployed-in-platformfrom
Conversation
zachmccormick
force-pushed
the
memcached-stuff
branch
from
f61d84d to
393b236
Compare
jasonpenny
reviewed
Apr 17, 2024
zachmccormick
force-pushed
the
memcached-stuff
branch
from
393b236 to
4c4539a
Compare
|
not worth adding tests? |
mattwd7
reviewed
Dec 5, 2025
| command = [operation, *args].join(' ').strip | ||
| else | ||
| # all operations except multiget have the key as the first arg | ||
| command = [operation, args[0]].join(' ').strip |
There was a problem hiding this comment.
This is a change for all operations outside of :send_multiget. Will this create problems?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to quantize the keys better.
Also provides a new LENGTH tag on the spans to help identify large cached items better