chore(deps): bump @opentui/solid from 0.1.87 to 0.2.10#816
chore(deps): bump @opentui/solid from 0.1.87 to 0.2.10#816dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@opentui/solid](https://github.com/anomalyco/opentui/tree/HEAD/packages/solid) from 0.1.87 to 0.2.10. - [Release notes](https://github.com/anomalyco/opentui/releases) - [Commits](https://github.com/anomalyco/opentui/commits/v0.2.10/packages/solid) --- updated-dependencies: - dependency-name: "@opentui/solid" dependency-version: 0.2.10 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/opencode/package.json">
<violation number="1" location="packages/opencode/package.json:102">
P1: Bumping `@opentui/solid` without also aligning `@opentui/core` introduces a potentially incompatible mixed OpenTUI runtime (`core` 0.1.87 vs 0.2.10). Keep these versions in lockstep to avoid cross-version type/runtime mismatches.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic
| "@openrouter/ai-sdk-provider": "1.5.4", | ||
| "@opentui/core": "0.1.87", | ||
| "@opentui/solid": "0.1.87", | ||
| "@opentui/solid": "0.2.10", |
There was a problem hiding this comment.
P1: Bumping @opentui/solid without also aligning @opentui/core introduces a potentially incompatible mixed OpenTUI runtime (core 0.1.87 vs 0.2.10). Keep these versions in lockstep to avoid cross-version type/runtime mismatches.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/opencode/package.json, line 102:
<comment>Bumping `@opentui/solid` without also aligning `@opentui/core` introduces a potentially incompatible mixed OpenTUI runtime (`core` 0.1.87 vs 0.2.10). Keep these versions in lockstep to avoid cross-version type/runtime mismatches.</comment>
<file context>
@@ -99,7 +99,7 @@
"@openrouter/ai-sdk-provider": "1.5.4",
"@opentui/core": "0.1.87",
- "@opentui/solid": "0.1.87",
+ "@opentui/solid": "0.2.10",
"@parcel/watcher": "2.5.1",
"@pierre/diffs": "catalog:",
</file context>
dev-punia-altimate
left a comment
There was a problem hiding this comment.
Multi-Persona Review — Verdict: block
The PR introduces two high-confidence SQL logic bugs that could cause incorrect filtering behavior and runtime errors, and one critical cross-repo dependency that must be addressed before merge. While the feature aligns with industry trends and is well-documented, the technical risks outweigh the benefits in its current state.
15/15 agents completed · 291s · 7 findings (2 critical, 1 high, 2 medium)
Critical
- [code-reviewer] The global_filter_str and individual_filter_str are constructed using ' AND '.join() but are not properly wrapped in parentheses when multiple filters are present, which could lead to incorrect SQL precedence and unintended filtering behavior. →
app/repositories/clickhouse_repositories/opportunities_repository.py:440- 💡 Wrap each filter string in parentheses when concatenating: f"AND ({global_filter_str})" if global_filter_str else ""
- [code-reviewer] The get_additional_filters() call may return None for filters/params, but the code assumes they are lists/dicts. If get_additional_filters() returns None for any of the four return values, the subsequent update() calls will fail with AttributeError. →
app/service/opportunities.py:1165- 💡 Initialize global_filters, individual_filters, global_params, individual_params as empty list/dict by default, and only assign if get_additional_filters() returns non-None values.
High
- [cross-repo-impact] Endpoint GET /opportunities/priority now accepts standard get_opportunities_data_request parameters (effort, status, owner, date-range, etc.) — frontend must update its query parameters to match. →
app/api/opportunities.py:264- 💡 Update AltimateAI/altimate-frontend#2727 to pass get_opportunities_data_request parameters (effort, status, owner, date-range) to /opportunities/priority endpoint
Medium
- [tech-lead] Service layer directly constructs and passes raw SQL filter strings to repository, bypassing abstraction. Filter logic is duplicated from
get_additional_filterswhich is intended for reuse but not clearly owned by a single layer. →app/service/opportunities.py:1141- 💡 Consider moving
get_additional_filterscall and filter parameter mapping into the repository layer, or define a dedicated filter translator service to maintain clear separation of concerns. Currently, service is doing data transformation that could belong to a dedicated filter adapter.
- 💡 Consider moving
- [code-reviewer] The function docstring mentions 'mirroring the Groups tab' — but CLAUDE.md in app/service/ explicitly requires all public API behavior to be documented with explicit contract semantics, not analogies like 'mirroring'. →
app/service/opportunities.py:1132- 💡 Replace 'mirroring the Groups tab' with a precise description of the filter application behavior: 'Applies the same global and individual ClickHouse filters as defined in get_additional_filters() for the main opportunities endpoint.'
Low
- [tech-lead] Variable names
global_filters,individual_filters,global_params,individual_paramsare ambiguous — unclear whether 'global' refers to tenant-wide or global table context. →app/service/opportunities.py:1145- 💡 Rename to
global_opportunity_filters,individual_opportunity_filters, etc., to align with repository method parameter names and clarify scope.
- 💡 Rename to
- [cto] The PR reuses existing filter logic via get_additional_filters() and applies it consistently across the priority endpoint, which is good. However, the parameter passing pattern (global/individual filters and params) is duplicated across three files and could benefit from a centralized filter builder class in the future to reduce surface area for drift.
- 💡 Consider creating a FilterBuilder class in app/utils/filters.py to encapsulate the logic of translating GetOpportunitiesDataRequest into ClickHouse clauses and params, improving maintainability as filter rules evolve.
Multi-Persona Review · vllm:qwen3-next-80b (waves) + vllm-fallback (synth) ·
Bumps @opentui/solid from 0.1.87 to 0.2.10.
Release notes
Sourced from @opentui/solid's releases.
... (truncated)
Commits
e1c483bRelease v0.2.109ab593dprepare release v0.2.9dde6af3fix keymap fallback priority (#1061)40ea4d9prepare release v0.2.88765e8dprepare release v0.2.7e663959prepare release v0.2.609b771eRelease v0.2.532d4e99split footer fixes (#1030)cfceed1prepare release v0.2.4422c4f3prepare release v0.2.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by cubic
Upgrade
@opentui/solidfrom 0.1.87 to 0.2.10 to pick up better markdown rendering, keymap fallback fixes, and improved Linux prebuild compatibility. Updates dependency inpackages/opencodeandpackages/plugin.Written for commit b3e5dec. Summary will update on new commits. Review in cubic