test: config — ConfigPaths.parseText substitution and JSONC parsing

[anandgupta42]

What does this PR do?\n\n1. ConfigPaths.parseText and ConfigPaths.substitute — src/config/paths.ts (11 new tests)\n\nThis module handles all config file loading: {env:VAR} token substitution, {file:path} file inclusion, and JSONC parsing with error reporting. Zero tests existed. This is the core config loading path — any bug here crashes the application or silently produces wrong config values for every user.\n\nNew coverage includes:\n\n**{env:VAR} substitution (2 tests):\n- Happy path: environment variable value is correctly interpolated into config\n- Missing env var: silently resolves to empty string (documents surprising behavior — a typo in var name produces no error)\n\n{file:path} substitution (5 tests):\n- Relative path resolution: {file:secret.txt} resolves relative to the config file's directory, not CWD\n- Absolute path: {file:/abs/path} bypasses relative resolution via path.isAbsolute() branch\n- Whitespace trimming: file content is .trim()'d — prevents trailing newlines from corrupting API keys\n- Missing file error: throws ConfigInvalidError with "does not exist" message pointing to the resolved path\n- Missing file with \"empty\" mode: gracefully returns empty string instead of throwing (used for optional file refs)\n- Comment awareness: {file:...} tokens inside // comment lines are skipped, preventing errors from documented example configs\n\nJSONC parsing (2 tests):**\n- Valid JSONC: comments and trailing commas parse correctly (validates jsonc-parser wiring)\n- Syntax error reporting: ConfigJsonError includes the file path, line/column numbers, and the full JSONC input for debugging\n- Error echo: the problematic input text is included in the error message so users can identify the issue\n\n### Type of change\n- [x] New feature (non-breaking change which adds functionality)\n\n### Issue for this PR\nN/A — proactive test coverage. ConfigPaths.parseText had zero tests despite being the config loading critical path.\n\n### How did you verify your code works?\n\n\nbun test test/config/paths.test.ts # 11 pass, 0 fail (287ms)\n\n\nTests were reviewed by a critic agent that:\n- Rejected 4 tests (duplicate code paths, trivially correct code)\n- Caught a critical bug: assertions used err.properties instead of err.data (would have silently passed while asserting nothing)\n- Approved 9 tests, 2 revised with the err.data fix\n\n### Checklist\n- [x] I have added tests that prove my fix is effective or that my feature works\n- [x] New and existing unit tests pass locally with my changes\n\nhttps://claude.ai/code/session_01LAyJZEAuipia1v9DZjbDCo

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for configuration path parsing, including environment variable substitution, file inclusion handling, and JSONC validation with robust error detection.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 795af954-5bc8-46c5-926c-7f798a05884c

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb13d4 and 905608f.

📒 Files selected for processing (1)

• packages/opencode/test/config/paths.test.ts

---

📝 Walkthrough

Walkthrough

A new Bun test suite was added for ConfigPaths.parseText that verifies environment variable substitution ({env:VAR}), file content substitution ({file:path}), JSONC parsing with comments and trailing commas, error handling for missing files and invalid JSONC, and behavior of substitution patterns within comments.

Changes

Cohort / File(s)	Summary
ConfigPaths Test Suite packages/opencode/test/config/paths.test.ts	Added comprehensive test coverage for parseText method including environment variable and file substitution, JSONC parsing validation, error handling for missing files and invalid JSONC with structured error details, and comment-context handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Suggested labels

contributor

Poem

🐰 A test suite hops in with care,
Checking vars and files everywhere,
JSONC comments skip unread,
Errors caught with data spread—
Config paths now safely tread! 🌿

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding tests for ConfigPaths.parseText substitution and JSONC parsing.
Description check	✅ Passed	The description covers all required template sections with substantial detail: Summary explains what changed and why, Test Plan documents verification with command and results, and Checklist items are completed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/test-config-paths-20260323-session_01LAyJZEAuipia1v9DZjbDCo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anandgupta42]

Consolidated into #403