fix: skill builder ctrl+i keybind, ESC navigation, docs screenshots#386
fix: skill builder ctrl+i keybind, ESC navigation, docs screenshots#386anandgupta42 merged 5 commits intomainfrom
Conversation
…and docs screenshots - Add `skill_list` keybind (default `ctrl+i`) to open skill browser globally - Fix ESC in Create/Install sub-dialogs to return to skill list instead of main - Remove dead `onCancel` callbacks from `DialogSkillCreate` and `DialogSkillInstall` - Add TUI screenshots to skills documentation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis change implements a global Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant KeybindHandler
participant DialogManager
participant SkillBrowser
participant CreateDialog
User->>KeybindHandler: Press ctrl+i
KeybindHandler->>DialogManager: Replace with SkillBrowser
DialogManager->>SkillBrowser: Display skill list
User->>SkillBrowser: Press ctrl+n
SkillBrowser->>DialogManager: Replace with CreateDialog<br/>(schedule reopenSkillList)
DialogManager->>CreateDialog: Display create form
User->>CreateDialog: Press ESC or submit
CreateDialog->>DialogManager: Close dialog
DialogManager->>SkillBrowser: Reopen skill list<br/>(via setTimeout)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/configure/skills.md`:
- Around line 123-135: Update the wording around the ctrl+i shortcut in the
Skill Browser docs to narrow its scope: remove claims like "from anywhere" and
"global shortcut" and state that ctrl+i opens the skill browser but is
intentionally ignored when another dialog is open so the browser's local
"Install" binding may take precedence; also clarify that typing `/skills` in the
prompt always opens the browser. Reference the ctrl+i key, the Install local
binding, and the `/skills` prompt command when editing the text and screenshot
caption.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3a880fbb-5bc3-4678-ab87-c9344c67fd53
⛔ Files ignored due to path filters (3)
docs/docs/assets/images/skills/tui-skill-browser.pngis excluded by!**/*.pngdocs/docs/assets/images/skills/tui-skill-create.pngis excluded by!**/*.pngdocs/docs/assets/images/skills/tui-skill-install.pngis excluded by!**/*.png
📒 Files selected for processing (4)
docs/docs/configure/skills.mdpackages/opencode/src/cli/cmd/tui/component/dialog-skill.tsxpackages/opencode/src/cli/cmd/tui/component/prompt/index.tsxpackages/opencode/src/config/config.ts
…ng, comments - Narrow ctrl+i docs scope: "when no other dialog is open" (CodeRabbit) - Merge duplicate ctrl+i rows in keybind table (consensus review) - Move dialog.clear() after validation in Create/Install onConfirm (Gemini) - Add explanatory comments for setTimeout tick deferral pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix `TrainingStore.count` mock: replace invalid `naming` key with `rule`, add missing `context` - Fix `fs.readFile` mock: return `Buffer.from()` instead of raw string Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
What does this PR do?
Fixes three issues with the skill builder TUI:
ctrl+iglobal keybind — Addsskill_listkeybind (defaultctrl+i) so users can open the skill browser from anywhere, not just via/skillsslash commandonClosecallback pattern as the action picker.skills.mdType of change
Issue for this PR
Closes #385
How did you verify your code works?
bun run typecheck— no new errors, all pre-existing in test files)bun run script/upstream/analyze.ts --markers --base main --strict)ctrl+iskips when dialog is open (dialog.stack.length > 0guard indialog-command.tsx:62), so no conflict with localctrl+ifor "install" inside the skill browserdialog.replace()withonClosecallback follows the exact same pattern used by the action picker (dialog-skill.tsx:512)Checklist
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation