Repository navigation
fix(provider): port upstream Bedrock unsigned reasoning filter (anomalyco/opencode#45769) #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
2
commits into
main
Choose a base branch
from
devin/1793814180-bedrock-unsigned-reasoning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -137,8 +137,18 @@ export namespace ProviderTransform { | |||||||||||||||||
| } | ||||||||||||||||||
| // altimate_change start — preserve signed empty reasoning blocks returned by Anthropic/Bedrock | ||||||||||||||||||
| if (part.type === "reasoning") { | ||||||||||||||||||
| const providerKey = model.api.npm === "@ai-sdk/amazon-bedrock" ? "bedrock" : "anthropic" | ||||||||||||||||||
| const opts = (part.providerOptions as any)?.[providerKey] | ||||||||||||||||||
| // altimate_change start — upstream_fix: drop unreplayable Bedrock reasoning before caching (anomalyco/opencode#45769) | ||||||||||||||||||
| // The Bedrock SDK only replays signed or redacted reasoning. Unsigned reasoning must go | ||||||||||||||||||
| // before cache points are assigned, or it can leave an empty or cache-point-only message. | ||||||||||||||||||
| if (model.api.npm === "@ai-sdk/amazon-bedrock") { | ||||||||||||||||||
| const options = part.providerOptions as Record<string, any> | undefined | ||||||||||||||||||
| const metadata = options?.[model.providerID] ?? options?.bedrock | ||||||||||||||||||
| return ( | ||||||||||||||||||
| metadata?.signature != null || metadata?.redactedContent != null || metadata?.redactedData != null | ||||||||||||||||||
| ) | ||||||||||||||||||
|
Comment on lines
+146
to
+148
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [🔵 LOW] The review checklist strictly prohibits the use of non-strict equality operators ( Suggested change:
Suggested change
|
||||||||||||||||||
| } | ||||||||||||||||||
| // altimate_change end | ||||||||||||||||||
| const opts = (part.providerOptions as any)?.anthropic | ||||||||||||||||||
| return part.text.trim().length > 0 || opts?.signature != null || opts?.redactedData != null | ||||||||||||||||||
| } | ||||||||||||||||||
| // altimate_change end | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🔵 LOW] According to the review checklist, avoid using the
anytype without providing an explanatory comment. If the exact type is unknown, consider usingunknown(e.g.,Record<string, unknown>), or add a comment explaining whyanyis necessary.Suggested change: