Skip to content

fix(telemetry): stop reporting user-cancelled tools as tool errors - #1630

Draft
altimate-software-factory[bot] wants to merge 1 commit into
mainfrom
factory/altimate_code/run-41258585016-1
Draft

altimate-software-factory[bot] wants to merge 1 commit into
mainfrom
factory/altimate_code/run-41258585016-1

Conversation

@altimate-software-factory

@altimate-software-factory altimate-software-factory Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Automated fix proposed by the Altimate software factory; a maintainer reviews every change.

The problem, fix and criteria below are the agent's own account; check them against the diff.

Problem

When a session is aborted, the processor marks still-running tool parts as errors with 'Tool execution aborted', and the prompt loop counted those as tool failures in error_fingerprint telemetry.

Fix

Tool parts closed because the user aborted the session are no longer sent as error_fingerprint tool errors, while aborts the session did not request and real tool errors are still reported.

Acceptance criteria

  • A tool part marked interrupted with error 'Tool execution aborted' produces no error_fingerprint event when the session abort signal was set
  • An interrupted tool part produces an error_fingerprint event when the session abort signal was not set
  • A tool error without interrupted metadata is still recorded during an aborted session

Changes

3 files changed, 43 lines added, 0 lines removed.

  • packages/opencode/src/altimate/telemetry/error-detail.ts
  • packages/opencode/src/session/prompt.ts
  • packages/opencode/test/telemetry/error-detail-requested-abort.test.ts

New tests

  • packages/opencode/test/telemetry/error-detail-requested-abort.test.ts

Independent review: accepted, confidence 0.82

Verification

  • Verify job: passed

Summary by cubic

Stops reporting tools the user cancelled as error_fingerprint tool errors.

When a session is aborted, tool parts interrupted by that abort were previously counted as tool failures in error_fingerprint telemetry. They're now skipped, while interrupts the session didn't request and real tool errors are still reported.

Written for commit 5d28063. Summary will update on new commits.

View guided diff Turn on auto-fix

Factory lane: altimate_code.
Agent-Authored-By: altimate-factory
@altimate-software-factory altimate-software-factory Bot added the agent-authored Opened by the software factory label Nov 1, 2026
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 005e32bd-f32d-44eb-baf8-072d2bd6d404

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.
  • "Cost side effects" section is missing or empty. Describe any model calls, queries or cloud resources whose cost grows with user data, or write "None".

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants