Repository navigation
fix(telemetry): stop reporting user-cancelled tools as tool errors - #1630
altimate-software-factory[bot] wants to merge 1 commit into
Conversation
Factory lane: altimate_code. Agent-Authored-By: altimate-factory
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Summary
Automated fix proposed by the Altimate software factory; a maintainer reviews every change.
The problem, fix and criteria below are the agent's own account; check them against the diff.
Problem
When a session is aborted, the processor marks still-running tool parts as errors with 'Tool execution aborted', and the prompt loop counted those as tool failures in error_fingerprint telemetry.
Fix
Tool parts closed because the user aborted the session are no longer sent as error_fingerprint tool errors, while aborts the session did not request and real tool errors are still reported.
Acceptance criteria
Changes
3 files changed, 43 lines added, 0 lines removed.
packages/opencode/src/altimate/telemetry/error-detail.tspackages/opencode/src/session/prompt.tspackages/opencode/test/telemetry/error-detail-requested-abort.test.tsNew tests
packages/opencode/test/telemetry/error-detail-requested-abort.test.tsIndependent review: accepted, confidence 0.82
Verification
Summary by cubic
Stops reporting tools the user cancelled as
error_fingerprinttool errors.When a session is aborted, tool parts interrupted by that abort were previously counted as tool failures in
error_fingerprinttelemetry. They're now skipped, while interrupts the session didn't request and real tool errors are still reported.Written for commit 5d28063. Summary will update on new commits.