Skip to content

fix(telemetry): stop reporting requested tool aborts as tool errors - #1627

Draft
altimate-software-factory[bot] wants to merge 1 commit into
mainfrom
factory/altimate_code/run-41072363529-1
Draft

altimate-software-factory[bot] wants to merge 1 commit into
mainfrom
factory/altimate_code/run-41072363529-1

Conversation

@altimate-software-factory

@altimate-software-factory altimate-software-factory Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Automated fix proposed by the Altimate software factory; a maintainer reviews every change.

The problem, fix and criteria below are the agent's own account; check them against the diff.

Problem

When a session is aborted, the processor closes running tools as errors with 'Tool execution aborted', and the prompt loop counted those requested cancellations as tool failures in error_fingerprint telemetry.

Fix

Error fingerprint telemetry now skips tools that were closed because the session itself was aborted, and still reports unrequested interruptions and real tool errors.

Acceptance criteria

  • A tool part with status error, error 'Tool execution aborted' and metadata.interrupted true produces no error_fingerprint when the session abort signal fired
  • The same interrupted part is still fingerprinted when the session abort signal did not fire
  • Real tool errors such as 'File not found' are still fingerprinted during an aborted session
  • An aborted-message part without the interrupted marker is still fingerprinted

Changes

3 files changed, 60 lines added, 0 lines removed.

  • packages/opencode/src/altimate/telemetry/error-detail.ts
  • packages/opencode/src/session/prompt.ts
  • packages/opencode/test/telemetry/error-fingerprint-requested-abort.test.ts

New tests

  • packages/opencode/test/telemetry/error-fingerprint-requested-abort.test.ts

Independent review: accepted, confidence 0.86

Verification

  • Verify job: passed

Summary by cubic

Stops reporting requested tool aborts as tool errors in error_fingerprint telemetry.

  • Skips tools the processor closed because the session's own abort signal fired (Stop/Esc, dispose), which is already recorded as the session's "aborted" outcome.
  • Interruptions the session did not request and real tool errors are still fingerprinted.
  • Adds isRequestedToolInterruption in packages/opencode/src/altimate/telemetry/error-detail.ts and a check in packages/opencode/src/session/prompt.ts.
  • Adds tests covering requested aborts, unrequested interruptions, real tool errors, and aborted parts without the interrupted marker.

Written for commit 4222260. Summary will update on new commits.

View guided diff Turn on auto-fix

Factory lane: altimate_code.
Agent-Authored-By: altimate-factory
@altimate-software-factory altimate-software-factory Bot added the agent-authored Opened by the software factory label Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e826079e-94f2-4714-a93b-a6a52960b76a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.
  • "Cost side effects" section is missing or empty. Describe any model calls, queries or cloud resources whose cost grows with user data, or write "None".

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants