Repository navigation
fix(session): stop reporting user-cancelled tools as tool errors - #1621
altimate-software-factory[bot] wants to merge 1 commit into
Conversation
Factory lane: altimate_code. Agent-Authored-By: altimate-factory
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Summary
Automated fix proposed by the Altimate software factory; a maintainer reviews every change.
The problem, fix and criteria below are the agent's own account; check them against the diff.
Problem
When a session was stopped, every unfinished tool part was closed as the error 'Tool execution aborted', and the prompt loop reported each one as an error_fingerprint tool failure even though the user had asked for the cancellation.
Fix
Tools the user's own Stop interrupted are no longer sent as error_fingerprint tool errors, while unrequested interruptions and real tool failures are still reported.
Acceptance criteria
Changes
3 files changed, 62 lines added, 0 lines removed.
packages/opencode/src/session/processor.tspackages/opencode/src/session/prompt.tspackages/opencode/test/session/processor-tool-abort-telemetry.test.tsNew tests
packages/opencode/test/session/processor-tool-abort-telemetry.test.tsIndependent review: accepted, confidence 0.88
Verification
Summary by cubic
Stops reporting tools interrupted by the user's own Stop as
error_fingerprinttool errors in telemetry.Written for commit dc23c97. Summary will update on new commits.