Repository navigation
fix(telemetry): classify permission denials as permission errors - #1618
altimate-software-factory[bot] wants to merge 1 commit into
Conversation
Factory lane: altimate_code. Agent-Authored-By: altimate-factory
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Summary
Automated fix proposed by the Altimate software factory; a maintainer reviews every change.
The problem, fix and criteria below are the agent's own account; check them against the diff.
Problem
The permission denial message includes the user's whole rule list as JSON, and the error classifier checks for the word parse before it checks for permission, so a rule such as dbt parse made the denial count as a parse error.
The telemetry message is the denial sentence followed by repeated permission entries, and a new test that builds a real denial with a dbt parse rule got parse_error before the fix and permission after it.
Fix
Tool calls blocked by permission rules or rejected by the user are now recorded as permission errors instead of parse errors in telemetry.
Acceptance criteria
Changes
2 files changed, 43 lines added, 0 lines removed.
packages/opencode/src/altimate/telemetry/index.tspackages/opencode/test/telemetry/classify-permission-denial.test.tsNew tests
packages/opencode/test/telemetry/classify-permission-denial.test.tsIndependent review: accepted, confidence 0.87
Verification
Summary by cubic
Fixes telemetry error classification so permission denials and user rejections are recorded as permission errors instead of parse errors.
dbt parse *), so permission checks now run before the parse-error keyword match.parse_error.Written for commit e79543f. Summary will update on new commits.