test(provider): expect the 300 s Altimate Base header timeout set by #1260 - #1265
test(provider): expect the 300 s Altimate Base header timeout set by #1260#1265anandgupta42 wants to merge 1 commit into
Conversation
…1260 #1260 raised FREE_TIER_HEADER_TIMEOUT_DEFAULT to 300_000 (the SSE chunk watchdog's 5 minutes, env-overridable) because the gateway can queue, cold-start or reason before flushing headers, but left the provider contract test asserting OpenAI's 10_000. main's TypeScript job has been red since. Closes #1264 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f1df395d-6c7a-4d7b-88eb-ab1bc0bcd3db) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Verified locally after all: applied the same one-line change on a checkout that contains main's provider.ts (#1260 merged), and test/provider/provider.test.ts passes: 88 pass, 0 fail. The PR body's "not run locally" line is superseded by this. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe provider test now expects Altimate Base’s five-minute header timeout. Its comment identifies the SSE watchdog default and the ChangesProvider contract validation
Priority: ➖ Normal — Impact reflects medium issue severity. Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This updates the Altimate Base provider contract test to match its five-minute header timeout without changing runtime behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the timeout line Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by deepseek-v4-pro · Input: 26.8K · Output: 2K · Cached: 169.1K Review guidance: REVIEW.md from base branch |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf18b8bba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Base can queue for capacity, cold-start, or reason before flushing headers, so #1260 | ||
| // set FREE_TIER_HEADER_TIMEOUT_DEFAULT to the SSE chunk watchdog's 5 minutes (env | ||
| // ALTIMATE_BASE_HEADER_TIMEOUT_MS overrides it; not set in this test). | ||
| expect(base.options.headerTimeout).toBe(300_000) |
There was a problem hiding this comment.
When the test runner inherits ALTIMATE_BASE_HEADER_TIMEOUT_MS (for example, a developer or CI job sets it to 600000 or off), freeTierHeaderTimeout() returns that override and this assertion fails even though the provider is behaving correctly. The comment only states that the variable is not set by this test; it does not remove the value captured from process.env. Clear the key from the instance's Env before calling Provider.list() so this test deterministically verifies the default.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
Issue for this PR
Closes #1264
Type of change
What does this PR do?
main'sTypeScriptjob has failed since #1260 on one assertion intest/provider/provider.test.ts: the Altimate Base provider contract test still expects the openai loader's 10 s header timeout, while #1260 deliberately raised it toFREE_TIER_HEADER_TIMEOUT_DEFAULT = 300_000(env-overridable viaALTIMATE_BASE_HEADER_TIMEOUT_MS) because the gateway can queue for capacity, cold-start, or reason before flushing headers. The assertion now expects300_000and its comment explains why the value is not OpenAI's default. One-line behavioural test change; no source change.How did you verify your code works?
Expected: 10000 Received: 300000); the other failures are the dbt-tools E2E ones fixed by fix(ci): validate cached dbt e2e environments; pin the uv venv to the system Python #1258.src/provider/provider.tson main setsheaderTimeout: freeTierHeaderTimeout()with default300_000and no env override in the test.Committed through the GitHub API from a fetched copy of main's test file.
Checklist
🤖 Generated with Claude Code
Note
Low Risk
Test-only change that documents and asserts existing provider timeout behavior; no runtime impact.
Overview
Fixes a TypeScript CI failure on
mainby aligning the Altimate Base provider contract test with behavior introduced in #1260. The assertion onbase.options.headerTimeoutnow expects300_000ms (5 minutes) instead of the OpenAI loader’s 10 s default.The updated comment documents why: Altimate Base can wait on queueing, cold start, or reasoning before response headers, so the default matches the SSE chunk watchdog and remains overridable via
ALTIMATE_BASE_HEADER_TIMEOUT_MS. No production code changes—only the test expectation and comment.Reviewed by Cursor Bugbot for commit bf18b8b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes the failing TypeScript job on main by updating the Altimate Base provider contract test to expect the 300-second header timeout introduced in #1260, replacing the previous 10-second default assertion.
Written for commit bf18b8b. Summary will update on new commits.
Summary by CodeRabbit
ALTIMATE_BASE_HEADER_TIMEOUT_MSenvironment variable.