Fix GEMM JAX starter: add missing C parameter to solve() - #315
Merged
kunal-mansukhani merged 1 commit intoAug 26, 2026
Merged
Conversation
adityasharmaaaaa
requested review from
ishaan-arya,
kunal-mansukhani and
shxjames
as code owners
August 26, 2026 00:43
kunal-mansukhani
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301.
The JAX starter's
solve()was missing theCaccumulator tensor thatthe harness passes (
alpha*A@B + beta*C), causing:TypeError: solve() takes 7 positional arguments but 8 were givenBrought the signature in line with the PyTorch/Triton starters for this
challenge and the existing pattern in
94_ssm_selective_scan's JAXstarter. Verified with
pre-commit run --all-files(black/isort/flake8/clang-format all pass).