dev to main release - #79
Merged
Merged
Conversation
* fix: try to use response times when correlating with hardware reward delivery times * fix: exclude unrewarded trials * refactor: overhaul function names to match behavior * test: update tests * refactor: make clear that non-rewwarded trials are excluded * fix: try temp fix using is rewarded from trial outcome for auto water * fix: test to use trial metadata for auto water to distinguish from anti bias * refactor: filter on whether trial was rewarded * refactor: use same logic across building both acquisition and trial table for auto * test: update tests * feat: add column for auto water offered to distinguish from auto water for rewards * docs: update docs * refactor: use the trial metadata to classify type * refactor: revert to use just auto label for acquisition series and update tests * docs: update docs
Collaborator
Author
|
i'm bypassing review since the PRs were already reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.