Skip to content

fix: Clarify orcid no match message - #244

Merged
dougollerenshaw merged 3 commits into
mainfrom
clarify-orcid-no-match-message
Oct 9, 2026
Merged

dougollerenshaw merged 3 commits into
mainfrom
clarify-orcid-no-match-message

Conversation

@dougollerenshaw

@dougollerenshaw dougollerenshaw commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Updates the error messages in the docstring for the orcid lookup tool to:

  • Make it clear that name matching alone is not enough - users must add either their affiliation or have a verified allen domain email
  • Provide a more useful message when the service errors. It's not always due to being off the network.

📚 Documentation preview 📚: https://scicomp-docs--244.org.readthedocs.build/en/244/

Closes #243

@dougollerenshaw

Copy link
Copy Markdown
Contributor Author

Note: I confirmed that my orcid still resolves on the network.

Then I confirmed that when I disconnected from the VPN, I get this:
image

I also verified that a 503 error now gives this:
image

@dougollerenshaw
dougollerenshaw merged commit 20da2eb into main Oct 9, 2026
1 check passed
@dougollerenshaw
dougollerenshaw deleted the clarify-orcid-no-match-message branch October 9, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message w/ failed ORCID lookup needs revision

2 participants