Skip to content

docs: add orcid test lookup - #242

Merged
dbirman merged 2 commits into
mainfrom
228-add-orcid-test-lookup
Oct 8, 2026
Merged

dbirman merged 2 commits into
mainfrom
228-add-orcid-test-lookup

Conversation

@dbirman

@dbirman dbirman commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

@dbirman dbirman linked an issue Oct 8, 2026 that may be closed by this pull request

@dougollerenshaw dougollerenshaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dougollerenshaw dougollerenshaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait. I was too hasty on that approval.

We should include a message that says what to do if a name doesn't resolve

@dougollerenshaw

dougollerenshaw commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Should be something like this:

If your name does not resolve to an ORCID, you should do the following:

  • Log in to orcid.org. Create a new account if you don't already have one
  • Ensure that your "Employment" section is up to date with your current Allen Institute affiliation
    and/or
  • Ensure that you have a verified email address that ends in "alleninstitute.org"

Seems like we should also say something about this being for internal Allen people only, given that these docs are actually publicly visible.

@dougollerenshaw

Copy link
Copy Markdown
Contributor

Ah, I see that it does give a message when the orcid fails to resolve:

image

That's probably sufficient. I'll approve.

@dougollerenshaw
dougollerenshaw self-requested a review October 8, 2026 21:16
@dbirman
dbirman merged commit 55cb449 into main Oct 8, 2026
1 check passed
@dbirman
dbirman deleted the 228-add-orcid-test-lookup branch October 8, 2026 21:17
@dougollerenshaw

Copy link
Copy Markdown
Contributor

I was working too fast here. Turns out that message above isn't quite correct. The ORCID lookup will not return an ID, even if it's a unique match, without either an allen affiliation or a verified email. That was a deliberate decision I made because I didn't want to return an incorrect exact match (for example, if someone at the allen had never registered with orcid they might not realize that someone else with an exact name match had already done so - leading to an incorrect attribution).

Sorry I didn't read that more closely and catch it yesterday. I was moving too fast and being sloppy. Followup PR coming now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ORCiD test lookup

2 participants