Skip to content

asl-say: Add tests#193

Merged
mkmer merged 4 commits intodevelopfrom
asl-say-tests
Mar 31, 2026
Merged

asl-say: Add tests#193
mkmer merged 4 commits intodevelopfrom
asl-say-tests

Conversation

@mkmer
Copy link
Copy Markdown
Contributor

@mkmer mkmer commented Mar 30, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Improved command-line argument validation with clearer error messages for missing or invalid inputs
    • Enhanced numeric parameter validation with specific error feedback
  • Tests

    • Added comprehensive test suite covering argument validation, error handling, and output verification across multiple operational modes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 29730bbc-5795-4f12-94cd-efa5bc5fa2a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch asl-say-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@mkmer mkmer requested review from jxmx March 30, 2026 14:58
@mkmer
Copy link
Copy Markdown
Contributor Author

mkmer commented Mar 30, 2026

The asl-say did not show usage if 0 args were provided (as I think it should have). Also confirm that the -n <NODE> is all numeric.

These "showed" themselves as I worked through the tests.

@mkmer mkmer merged commit 5368b3f into develop Mar 31, 2026
7 checks passed
@mkmer mkmer deleted the asl-say-tests branch March 31, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant