Skip to content

[DPG] add mc event validation qa task - #18743

Merged
altsybee merged 4 commits into
AliceO2Group:masterfrom
altsybee:master
Nov 14, 2026
Merged

altsybee merged 4 commits into
AliceO2Group:masterfrom
altsybee:master

Conversation

@altsybee

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 35 warnings, 🔕 13 disabled

@github-actions github-actions Bot changed the title add mc event validation qa task [DPG] add mc event validation qa task Nov 13, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 1e46a77 at 2026-11-13 22:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/DPG/Tasks/AOTEvent/mcEventValidation.cxx:121:70: error: arithmetic between enumeration type 'McEventValidationTask::BcCategory' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1e46a77 at 2026-11-13 23:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 74 warnings.'
Found 2 errors and 74 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/989a1b10c79b8daa55b460c971a909fafcbfeb95/O2Physics-code-check/errors.txt
DPG/Tasks/AOTEvent/mcEventValidation.cxx:62:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTEvent/mcEventValidation.cxx:121:70: error: arithmetic between enumeration type 'McEventValidationTask::BcCategory' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
++ [[ 74 -gt 0 ]]
++ cat /sw/BUILD/989a1b10c79b8daa55b460c971a909fafcbfeb95/O2Physics-code-check/warnings.txt
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:52:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:671:27: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:740:36: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:743:43: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:744:45: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:745:48: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:774:32: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:777:30: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:779:30: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:800:27: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:800:27: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:800:45: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:806:32: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:807:32: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:808:32: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:828:29: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:828:29: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:828:49: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:828:69: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:837:26: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:839:28: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:841:27: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:843:29: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:845:46: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:850:26: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:852:28: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:854:27: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:856:29: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:858:46: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:866:21: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:871:21: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx:876:21: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 1e46a77 at 2026-11-13 23:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/DPG/Tasks/AOTEvent/mcEventValidation.cxx:121:70: error: arithmetic between enumeration type 'McEventValidationTask::BcCategory' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@altsybee
altsybee enabled auto-merge (squash) November 14, 2026 09:18

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @altsybee.

@altsybee
altsybee merged commit 42859ff into AliceO2Group:master Nov 14, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants