Repository navigation
[PWGJE] EMCal correction task: apply MC cell corrections after cross-… - #18727
Merged
mhemmer-cern merged 1 commit intoNov 13, 2026
Merged
Conversation
…talk In processMCFull and processMCWithSecondaries the shaper correction was applied to low-gain cells twice: once while converting the cells, and again after the cross-talk emulation. The second pass did not check hasShaperCorrection, so it also ran when the correction was disabled. All MC cell corrections now happen in one loop after the cross-talk emulation, in this order: - shaper correction for LG cells (only if hasShaperCorrection is set) - mcCellEnergyShift - mcCellEnergyResolutionBroadening - cell time shift and smearing (getCellTimeShift), evaluated with the corrected cell energy As a result: - the cross-talk emulation works on the uncorrected cell amplitudes and times - cells added by the cross-talk emulation now also get the energy shift, resolution broadening and time shift/smearing - hCellEnergyDistAfter is filled after the corrections, and its title says so
|
O2 linter results: ❌ 0 errors, |
mhemmer-cern
marked this pull request as ready for review
November 13, 2026 10:49
mhemmer-cern
requested review from
alibuild,
fjonasALICE,
jaimenorman and
nzardosh
as code owners
November 13, 2026 10:50
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
The logic looks good to me! Thanks @mhemmer-cern |
mhemmer-cern
enabled auto-merge (squash)
November 13, 2026 16:04
alibuild
approved these changes
Nov 13, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…talk
In processMCFull and processMCWithSecondaries the shaper correction was applied to low-gain cells twice: once while converting the cells, and again after the cross-talk emulation. The second pass did not check hasShaperCorrection, so it also ran when the correction was disabled.
All MC cell corrections now happen in one loop after the cross-talk emulation, in this order:
As a result: