Skip to content

[PWGDQ] Fixing linter errors in VarManager - #18698

Merged
iarsene merged 17 commits into
AliceO2Group:masterfrom
axti98:DQRefactor
Nov 13, 2026
Merged

iarsene merged 17 commits into
AliceO2Group:masterfrom
axti98:DQRefactor

Conversation

@axti98

@axti98 axti98 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Refactoring of the DQ Variable Manager to fix linter issues.

Introducing a DQConstants.h header to define constants that are known at compile time to improve code readability.

@github-actions github-actions Bot added the pwgdq label Nov 11, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 501 warnings, 🔕 1 disabled

@axti98
axti98 marked this pull request as draft November 11, 2026 20:15
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4cf94e2 at 2026-11-11 21:32:

## sw/BUILD/O2Physics-latest/log
2026-11-11T20:58:18.115+0100 [34457:139648500570176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:20.301+0100 [34427:140227618838592] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:18.157+0100 [36235:139622721976384] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:18.158+0100 [36235:139622721976384] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"
2026-11-11T20:58:18.596+0100 [36260:140077489137728] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:18.596+0100 [36260:140077489137728] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"
2026-11-11T20:58:21.420+0100 [36306:140230632585280] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:21.420+0100 [36306:140230632585280] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"
2026-11-11T20:58:22.181+0100 [36329:140174077286464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"]
2026-11-11T20:58:22.181+0100 [36329:140174077286464] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: connection error: desc = "transport: Error while dialing: dial tcp: lookup bb-services-central-storage.service.consul on 137.138.31.52:53: no such host"


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 24 warnings.'
Found 1 errors and 24 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/1c62c2309090c031a03da45124b2b0aee02ce776/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/1c62c2309090c031a03da45124b2b0aee02ce776/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3018:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3028:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3029:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1264:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1265:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1650:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1681:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1685:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3500:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3501:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4765:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
[0 more errors; see full log]

Full log here.

@axti98
axti98 marked this pull request as ready for review November 12, 2026 07:06
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5269ff8 at 2026-11-12 08:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 24 warnings.'
Found 1 errors and 24 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/e63dbbc25adb0ea109f5d5ff4494909e30f71981/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/e63dbbc25adb0ea109f5d5ff4494909e30f71981/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3018:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3028:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3029:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1264:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1265:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1650:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1681:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1685:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3500:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3501:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4765:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5498:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5501:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5502:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7299:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 803801d at 2026-11-12 12:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 24 warnings.'
Found 1 errors and 24 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/6e59545e678eb47462b076b2f678eb4f22787fa8/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/6e59545e678eb47462b076b2f678eb4f22787fa8/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3028:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3038:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3039:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1266:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1267:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1652:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1687:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3502:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3503:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4767:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5500:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5503:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5504:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7303:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 190f7b7 at 2026-11-12 13:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:291:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:298:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:343:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:351:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 190f7b7 at 2026-11-12 13:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:291:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:298:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:343:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:351:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 190f7b7 at 2026-11-12 13:32:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:291:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:298:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:343:33: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.cxx:351:31: error: 'InvalidValue' is not a member of 'o2::dqconstants'; did you mean 'InvalidValueI'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2824:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2771:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2788:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2798:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2811:7: error: there are no arguments to 'IsStdDevValid' that depend on a template parameter, so a declaration of 'IsStdDevValid' must be available [-fpermissive]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 906bec0 at 2026-11-12 16:03:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 24 warnings.'
Found 1 errors and 24 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/56d5a5ad7f755391e07a016be1d164bad87f2769/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/56d5a5ad7f755391e07a016be1d164bad87f2769/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3028:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3038:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3039:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1266:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1267:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1652:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1687:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3502:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3503:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4767:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5500:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5503:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5504:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7303:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Comment thread PWGDQ/Core/DQConstants.h Resolved
@vkucera

vkucera commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@axti98 Very nice! Thanks!

Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
Comment thread PWGDQ/Core/VarManager.h Resolved
@iarsene

iarsene commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@axti98 I suggest renaming this PR to something like "Fixing linter errors in VarManager" because refactoring would involve more structural changes, which is not the case here.

@axti98 axti98 changed the title [PWGDQ] Refactoring of DQ VarManager [PWGDQ] Fixing linter errors in VarManager Nov 13, 2026
@axti98
axti98 requested review from iarsene and vkucera November 13, 2026 11:46
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5c6d097 at 2026-11-13 12:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 24 warnings.'
Found 3 errors and 24 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/0b6e5f0d651f809962b72ce2808d2db6ff07accd/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2850:23: error: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2862:23: error: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/0b6e5f0d651f809962b72ce2808d2db6ff07accd/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3028:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3038:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3039:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1266:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1267:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1652:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1687:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3495:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3496:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4760:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5493:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5496:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5497:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7296:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 5c6d097 at 2026-11-13 13:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2850:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2862:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2850:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2862:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2850:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2862:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2850:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2862:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2850:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Core/VarManager.h:2862:23: error: comparison of integer expressions of different signedness: 'int' and 'std::array<float, 7>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d97a509 at 2026-11-13 13:41:

## sw/BUILD/O2-latest/log
2026-11-13T13:40:20.302+0100 [51798:140019381980800] [executioncontext.cpp:739] [ERROR] Failed to download output blob 4a1af663d2073f48fc5a80eb489846c0c864dbba02e1aebca3f41eab8cdd51ae: 13: Blob absent from sink after replication: Object not found
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d97a509 at 2026-11-13 13:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 24 warnings.'
Found 3 errors and 24 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/0cfa57842d8d2636d24c81577f70cbd1b962057b/O2Physics-code-check/errors.txt
PWGDQ/Core/DQConstants.h:20:1: error: included header cstdint is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2850:15: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/0cfa57842d8d2636d24c81577f70cbd1b962057b/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3028:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3038:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3039:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1266:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1267:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1652:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1687:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3495:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3496:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4760:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5493:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5496:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5497:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7296:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

iarsene
iarsene previously approved these changes Nov 13, 2026
@iarsene
iarsene enabled auto-merge (squash) November 13, 2026 12:51
@vkucera

vkucera commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

@axti98 Please fix the includes.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3b18ea0 at 2026-11-13 15:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 24 warnings.'
Found 2 errors and 24 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/8fdcf2feb0a80bbdff8a850e91ae45cfd9294e00/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:43:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2850:15: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/8fdcf2feb0a80bbdff8a850e91ae45cfd9294e00/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:58:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:59:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:61:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:73:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:99:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:153:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:315:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:422:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:489:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:3028:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3038:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3039:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1266:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1267:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1652:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1687:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3495:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3496:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4760:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5493:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5496:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5497:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7296:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@axti98
axti98 requested a review from iarsene November 13, 2026 14:54
@iarsene
iarsene merged commit c966efb into AliceO2Group:master Nov 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants