Skip to content

[PWGEM/PhotonMeson] Add option for fast analytical propagation of tracks - #17288

Open
jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master
Open

[PWGEM/PhotonMeson] Add option for fast analytical propagation of tracks#17288
jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator
  • Photonconversion builder is slow due to many propagation of the tracks to the primary vertex etc.
  • Add a fast routine to calcuate DCA and Phiv, Psi-Pair from the track helix.
  • Add histograms to compare the results of both methods

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 40 errors, ⚠️ 79 warnings, 🔕 1 disabled

@alibuild

alibuild commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9fd35fe at 2026-08-02 21:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 0 warnings.'
Found 14 errors and 0 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/dc3023d3964e40f78b5cd4b3ab8d2057b969d325/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:567:21: error: no header providing "o2::math_utils::Point3D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:632:18: error: no header providing "o2::track::TrackAuxPar" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:662:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:667:26: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:685:11: error: do not use 'else' after 'break' [readability-else-after-return,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:33:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:40:12: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:41:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:62:235: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:116:130: error: no header providing "o2::math_utils::Point3D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:119:3: error: uninitialized record type: 'dca' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:172:20: error: no header providing "o2::soa::is_iterator" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:193:3: error: uninitialized record type: 'trackP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:203:87: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 14 -gt 0 ]]
++ exit 1
--

Full log here.

@mhemmer-cern

Copy link
Copy Markdown
Collaborator

Some of the code-check errors are take care of in PR #17285

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4753198 at 2026-08-03 10:36:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 12 errors and 0 warnings.'
Found 12 errors and 0 warnings.
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/794bae21c0f9311d57f262454ff1e4428f55f1f4/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:573:21: error: no header providing "o2::math_utils::Point3D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:638:18: error: no header providing "o2::track::TrackAuxPar" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:684:11: error: do not use 'else' after 'break' [readability-else-after-return,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:33:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:40:12: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:41:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:62:235: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:116:130: error: no header providing "o2::math_utils::Point3D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:119:3: error: uninitialized record type: 'dca' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:166:20: error: no header providing "o2::soa::is_iterator" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:181:3: error: uninitialized record type: 'trackP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/PCMUtilities.h:191:87: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 12 -gt 0 ]]
++ exit 1
--

Full log here.

@jokonig
jokonig enabled auto-merge (squash) August 3, 2026 09:20
alibuild
alibuild previously approved these changes Aug 3, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jokonig.

- Photonconversion builder is slow due to many propagation of the tracks to the primary vertex etc.
- Add a fast routine to calcuate DCA and Phiv, Psi-Pair from the track helix.
- Add histograms to compare the results of both methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants