Skip to content

[PWGLF] Added the Mis-IDentified PID cut - #17287

Merged
smaff92 merged 38 commits into
AliceO2Group:masterfrom
JimunLee:master
Aug 4, 2026
Merged

[PWGLF] Added the Mis-IDentified PID cut#17287
smaff92 merged 38 commits into
AliceO2Group:masterfrom
JimunLee:master

Conversation

@JimunLee

@JimunLee JimunLee commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Dear experts,

It's added a mis-identified particle function code.

Thank you,
Jimun

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 3661135 at 2026-08-03 07:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1819:22: error: 'dR_kaon' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1820:22: error: 'dR_pion' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1815:20: error: 'dR_k_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1816:20: error: 'dR_pi_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 571352b at 2026-08-03 11:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1819:22: error: 'dR_kaon' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1820:22: error: 'dR_pion' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1815:20: error: 'dR_k_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1816:20: error: 'dR_pi_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 53a2209 at 2026-08-03 11:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1816:22: error: 'dR_kaon' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1817:22: error: 'dR_pion' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1812:20: error: 'dR_k_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1813:20: error: 'dR_pi_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 571352b at 2026-08-03 11:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 177 warnings.'
Found 19 errors and 177 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/e40b8f2b588b4eb0a696fa7fdd71fc544a3e66fa/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:57:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:63:8: error: Excessive padding in 'struct kstarInOO' (36 padding bytes, where 4 is optimal). Optimal fields order: cache, massKa, massPi, eventSelectionBits, RealTriggerMaskBits, triggerMaskBitsTest1, triggerMaskBitsTest2, triggerMaskBitsTest3, JEPosZFilter, JEMCPosZFilter, JetCuts, cfgEventVtxCut, cfgEventMaxEta, cfgTrackMinPt, cfgTrackMaxEta, cfgTrackMaxDCArToPVcut, cfgTrackMaxDCAzToPVcut, cfgTrackGlobalSel, cfgTrackPrimaryTrack, cfgTrackConnectedToPV, cfgTrackGlobalWoDCATrack, cfgTrackFindableTPCClusters, cfgTrackTPCCrossedRows, cfgTrackRowsOverFindable, cfgTrackTPCChi2, cfgTrackITSChi2, cfgTrackTPCPID, cfgTrackTOFPID, cfgTrackSquarePIDCut, cfgTrackCirclePIDCut, cfgTrackCircleValue, cfgTrackTOFHard, isMIDCut, cfgTrackTPCPIDnSig, cfgTrackTOFPIDnSig, cfgMIDnSig, cDebugLevel, cfgMixNMixedEvents, cfgVtxMixCut, cfgForceGenReco, cfgReqMcEffPID, cfgReqMcEffTrackQA, cfgMinvNBins, cfgMinvMin, cfgMinvMax, cfgEventCutQA, cfgTrackCutQA, cfgJetQAHistos, cfgMCHistos, cfgMixedHistos, cfgJetHistos, cfgJetMCHistos, cfgJetdRHistos, cfgCutonTrig, cfgJetpT, cfgJetR, cfgJetdR, cfgJetMaxEta, cfgSingleJet, cfgReqJets, cfgForceTrueINELgt, cfgCentAxis, cfgBinsMixMult, cfgBinsMixVtx, binsDCAz, binsDCAxy, kaon, pion, kaonMC, pionMC, doprocessDataJets, doprocessMCJets, doprocessDataSameEvent, doprocessDataMixedEvent, doprocessSameEventMC, doprocessMixedEventMC, doprocessGen, doprocessGenJets, doprocessJetQA, cfgEventSelections, cfgRealTriggerMasks, cfgTriggerMasksTest1, cfgTriggerMasksTest2, cfgTriggerMasksTest3, perCollision, histos, nJetEvents, nJetMCEvents, nEvents, nEventsMix, nEventsMC, nEventsMCMix, nEventsGen, nprocessGenEvents, ndRtest, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:522:55: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:578:58: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:597:40: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:673:21: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:727:21: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:841:12: error: variable 'track1_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:841:25: error: variable 'track2_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:917:73: error: the parameter 'lResonance' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:928:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1112:16: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1114:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1122:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1202:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1770:14: error: variable 'dR_kaon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1770:23: error: variable 'dR_pion' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1770:32: error: variable 'dR_k_kstar' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1770:44: error: variable 'dR_pi_kstar' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 177 -gt 0 ]]
++ cat /sw/BUILD/e40b8f2b588b4eb0a696fa7fdd71fc544a3e66fa/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:474:12: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:476:6: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:479:12: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:481:6: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:489:14: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:491:8: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:494:14: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:496:8: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:529:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:534:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:539:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:544:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:549:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:554:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:559:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:564:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:587:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:603:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:605:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:607:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:609:58: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 53a2209 at 2026-08-03 12:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 177 warnings.'
Found 19 errors and 177 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/28ee3bf381aca96ee0bfece146987be5896225da/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:57:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:63:8: error: Excessive padding in 'struct kstarInOO' (36 padding bytes, where 4 is optimal). Optimal fields order: cache, massKa, massPi, eventSelectionBits, RealTriggerMaskBits, triggerMaskBitsTest1, triggerMaskBitsTest2, triggerMaskBitsTest3, JEPosZFilter, JEMCPosZFilter, JetCuts, cfgEventVtxCut, cfgEventMaxEta, cfgTrackMinPt, cfgTrackMaxEta, cfgTrackMaxDCArToPVcut, cfgTrackMaxDCAzToPVcut, cfgTrackGlobalSel, cfgTrackPrimaryTrack, cfgTrackConnectedToPV, cfgTrackGlobalWoDCATrack, cfgTrackFindableTPCClusters, cfgTrackTPCCrossedRows, cfgTrackRowsOverFindable, cfgTrackTPCChi2, cfgTrackITSChi2, cfgTrackTPCPID, cfgTrackTOFPID, cfgTrackSquarePIDCut, cfgTrackCirclePIDCut, cfgTrackCircleValue, cfgTrackTOFHard, isMIDCut, cfgTrackTPCPIDnSig, cfgTrackTOFPIDnSig, cfgMIDnSig, cDebugLevel, cfgMixNMixedEvents, cfgVtxMixCut, cfgForceGenReco, cfgReqMcEffPID, cfgReqMcEffTrackQA, cfgMinvNBins, cfgMinvMin, cfgMinvMax, cfgEventCutQA, cfgTrackCutQA, cfgJetQAHistos, cfgMCHistos, cfgMixedHistos, cfgJetHistos, cfgJetMCHistos, cfgJetdRHistos, cfgCutonTrig, cfgJetpT, cfgJetR, cfgJetdR, cfgJetMaxEta, cfgSingleJet, cfgReqJets, cfgForceTrueINELgt, cfgCentAxis, cfgBinsMixMult, cfgBinsMixVtx, binsDCAz, binsDCAxy, kaon, pion, kaonMC, pionMC, doprocessDataJets, doprocessMCJets, doprocessDataSameEvent, doprocessDataMixedEvent, doprocessSameEventMC, doprocessMixedEventMC, doprocessGen, doprocessGenJets, doprocessJetQA, cfgEventSelections, cfgRealTriggerMasks, cfgTriggerMasksTest1, cfgTriggerMasksTest2, cfgTriggerMasksTest3, perCollision, histos, nJetEvents, nJetMCEvents, nEvents, nEventsMix, nEventsMC, nEventsMCMix, nEventsGen, nprocessGenEvents, ndRtest, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:521:55: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:577:58: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:596:40: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:672:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:726:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:838:12: error: variable 'track1_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:838:25: error: variable 'track2_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:914:73: error: the parameter 'lResonance' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:925:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1109:16: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1111:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1119:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1199:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1767:14: error: variable 'dR_kaon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1767:23: error: variable 'dR_pion' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1767:32: error: variable 'dR_k_kstar' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1767:44: error: variable 'dR_pi_kstar' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 177 -gt 0 ]]
++ cat /sw/BUILD/28ee3bf381aca96ee0bfece146987be5896225da/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:473:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:475:15: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:478:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:480:15: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:488:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:490:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:493:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:495:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:528:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:533:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:538:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:543:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:548:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:553:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:558:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:563:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:586:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:602:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:604:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:606:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:608:58: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 53a2209 at 2026-08-03 12:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1816:22: error: 'dR_kaon' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1817:22: error: 'dR_pion' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1812:20: error: 'dR_k_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1813:20: error: 'dR_pi_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 1a29237 at 2026-08-03 12:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1816:22: error: 'dR_kaon' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1817:22: error: 'dR_pion' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1812:20: error: 'dR_k_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:1813:20: error: 'dR_pi_kstar' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d8558f8 at 2026-08-03 13:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 15 errors and 177 warnings.'
Found 15 errors and 177 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/c2b47e4eb91b0474f69cd3b327446a0ef3ccc538/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:57:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:63:8: error: Excessive padding in 'struct kstarInOO' (36 padding bytes, where 4 is optimal). Optimal fields order: cache, massKa, massPi, eventSelectionBits, RealTriggerMaskBits, triggerMaskBitsTest1, triggerMaskBitsTest2, triggerMaskBitsTest3, JEPosZFilter, JEMCPosZFilter, JetCuts, cfgEventVtxCut, cfgEventMaxEta, cfgTrackMinPt, cfgTrackMaxEta, cfgTrackMaxDCArToPVcut, cfgTrackMaxDCAzToPVcut, cfgTrackGlobalSel, cfgTrackPrimaryTrack, cfgTrackConnectedToPV, cfgTrackGlobalWoDCATrack, cfgTrackFindableTPCClusters, cfgTrackTPCCrossedRows, cfgTrackRowsOverFindable, cfgTrackTPCChi2, cfgTrackITSChi2, cfgTrackTPCPID, cfgTrackTOFPID, cfgTrackSquarePIDCut, cfgTrackCirclePIDCut, cfgTrackCircleValue, cfgTrackTOFHard, isMIDCut, cfgTrackTPCPIDnSig, cfgTrackTOFPIDnSig, cfgMIDnSig, cDebugLevel, cfgMixNMixedEvents, cfgVtxMixCut, cfgForceGenReco, cfgReqMcEffPID, cfgReqMcEffTrackQA, cfgMinvNBins, cfgMinvMin, cfgMinvMax, cfgEventCutQA, cfgTrackCutQA, cfgJetQAHistos, cfgMCHistos, cfgMixedHistos, cfgJetHistos, cfgJetMCHistos, cfgJetdRHistos, cfgCutonTrig, cfgJetpT, cfgJetR, cfgJetdR, cfgJetMaxEta, cfgSingleJet, cfgReqJets, cfgForceTrueINELgt, cfgCentAxis, cfgBinsMixMult, cfgBinsMixVtx, binsDCAz, binsDCAxy, kaon, pion, kaonMC, pionMC, doprocessDataJets, doprocessMCJets, doprocessDataSameEvent, doprocessDataMixedEvent, doprocessSameEventMC, doprocessMixedEventMC, doprocessGen, doprocessGenJets, doprocessJetQA, cfgEventSelections, cfgRealTriggerMasks, cfgTriggerMasksTest1, cfgTriggerMasksTest2, cfgTriggerMasksTest3, perCollision, histos, nJetEvents, nJetMCEvents, nEvents, nEventsMix, nEventsMC, nEventsMCMix, nEventsGen, nprocessGenEvents, ndRtest, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:521:55: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:577:58: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:596:40: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:672:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:726:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:838:12: error: variable 'track1_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:838:25: error: variable 'track2_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:914:73: error: the parameter 'lResonance' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:925:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1109:16: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1111:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1119:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1199:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
++ [[ 177 -gt 0 ]]
++ cat /sw/BUILD/c2b47e4eb91b0474f69cd3b327446a0ef3ccc538/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:473:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:475:15: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:478:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:480:15: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:488:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:490:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:493:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:495:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:528:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:533:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:538:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:543:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:548:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:553:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:558:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:563:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:586:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:602:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:604:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:606:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:608:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:610:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:612:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:614:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:616:98: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0455d70 at 2026-08-03 19:05:

## sw/BUILD/O2Physics-latest/log
2026-08-03T18:37:52.883+0200 [25:139914943932992] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.883+0200 [25:139914943932992] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:39:31.899+0200 [25:139914943932992] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.042+0200 [32:139717948140096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.042+0200 [32:139717948140096] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:12.084+0200 [32:139717948140096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.929+0200 [26:140691924081216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.930+0200 [26:140691924081216] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:22.737+0200 [26:140691924081216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.064+0200 [28:139667457698368] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.064+0200 [28:139667457698368] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:41.287+0200 [28:139667457698368] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.934+0200 [27:140634796837440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.934+0200 [27:140634796837440] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:42.312+0200 [27:140634796837440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.043+0200 [29:140341735758400] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.044+0200 [29:140341735758400] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:43.403+0200 [29:140341735758400] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.993+0200 [23:140347167840832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.994+0200 [23:140347167840832] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:43.427+0200 [23:140347167840832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.970+0200 [30:140591931693632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:52.970+0200 [30:140591931693632] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:40:45.826+0200 [30:140591931693632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.058+0200 [33:139859201714752] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.058+0200 [33:139859201714752] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:41:02.136+0200 [33:139859201714752] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.020+0200 [31:140147917576768] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.021+0200 [31:140147917576768] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:41:09.134+0200 [31:140147917576768] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.208+0200 [34:139906949786176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.208+0200 [34:139906949786176] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:42:42.916+0200 [34:139906949786176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.148+0200 [24:139820259465792] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-03T18:37:53.148+0200 [24:139820259465792] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-03T18:45:18.567+0200 [24:139820259465792] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 183 warnings.'
Found 13 errors and 183 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/19c80693b3e9502573faec5a24dffdd8ae026e73/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:57:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:63:8: error: Excessive padding in 'struct kstarInOO' (36 padding bytes, where 4 is optimal). Optimal fields order: cache, massKa, massPi, eventSelectionBits, RealTriggerMaskBits, triggerMaskBitsTest1, triggerMaskBitsTest2, triggerMaskBitsTest3, JEPosZFilter, JEMCPosZFilter, JetCuts, cfgEventVtxCut, cfgEventMaxEta, cfgTrackMinPt, cfgTrackMaxEta, cfgTrackMaxDCArToPVcut, cfgTrackMaxDCAzToPVcut, cfgTrackGlobalSel, cfgTrackPrimaryTrack, cfgTrackConnectedToPV, cfgTrackGlobalWoDCATrack, cfgTrackFindableTPCClusters, cfgTrackTPCCrossedRows, cfgTrackRowsOverFindable, cfgTrackTPCChi2, cfgTrackITSChi2, cfgTrackTPCPID, cfgTrackTOFPID, cfgTrackSquarePIDCut, cfgTrackCirclePIDCut, cfgTrackCircleValue, cfgTrackTOFHard, isMIDCut, cfgTrackTPCPIDnSig, cfgTrackTOFPIDnSig, cfgMIDnSig, cDebugLevel, cfgMixNMixedEvents, cfgVtxMixCut, cfgForceGenReco, cfgReqMcEffPID, cfgReqMcEffTrackQA, cfgMinvNBins, cfgMinvMin, cfgMinvMax, cfgEventCutQA, cfgTrackCutQA, cfgJetQAHistos, cfgMCHistos, cfgMixedHistos, cfgJetHistos, cfgJetMCHistos, cfgJetdRHistos, cfgCutonTrig, cfgJetpT, cfgJetR, cfgJetdR, cfgJetMaxEta, cfgSingleJet, cfgReqJets, cfgForceTrueINELgt, cfgCentAxis, cfgBinsMixMult, cfgBinsMixVtx, binsDCAz, binsDCAxy, kaon, pion, kaonMC, pionMC, doprocessDataJets, doprocessMCJets, doprocessDataSameEvent, doprocessDataMixedEvent, doprocessSameEventMC, doprocessMixedEventMC, doprocessGen, doprocessGenJets, doprocessJetQA, cfgEventSelections, cfgRealTriggerMasks, cfgTriggerMasksTest1, cfgTriggerMasksTest2, cfgTriggerMasksTest3, perCollision, histos, nJetEvents, nJetMCEvents, nEvents, nEventsMix, nEventsMC, nEventsMCMix, nEventsGen, nprocessGenEvents, ndRtest, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:521:55: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a693e80 at 2026-08-04 03:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 2 warnings.'
Found 13 errors and 2 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/0f64d25a577609c15d846b15ff1a117acef2d513/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:57:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:63:8: error: Excessive padding in 'struct kstarInOO' (36 padding bytes, where 4 is optimal). Optimal fields order: cache, massKa, massPi, eventSelectionBits, RealTriggerMaskBits, triggerMaskBitsTest1, triggerMaskBitsTest2, triggerMaskBitsTest3, JEPosZFilter, JEMCPosZFilter, JetCuts, cfgEventVtxCut, cfgEventMaxEta, cfgTrackMinPt, cfgTrackMaxEta, cfgTrackMaxDCArToPVcut, cfgTrackMaxDCAzToPVcut, cfgTrackGlobalSel, cfgTrackPrimaryTrack, cfgTrackConnectedToPV, cfgTrackGlobalWoDCATrack, cfgTrackFindableTPCClusters, cfgTrackTPCCrossedRows, cfgTrackRowsOverFindable, cfgTrackTPCChi2, cfgTrackITSChi2, cfgTrackTPCPID, cfgTrackTOFPID, cfgTrackSquarePIDCut, cfgTrackCirclePIDCut, cfgTrackCircleValue, cfgTrackTOFHard, isMIDCut, cfgTrackTPCPIDnSig, cfgTrackTOFPIDnSig, cfgMIDnSig, cDebugLevel, cfgMixNMixedEvents, cfgVtxMixCut, cfgForceGenReco, cfgReqMcEffPID, cfgReqMcEffTrackQA, cfgMinvNBins, cfgMinvMin, cfgMinvMax, cfgEventCutQA, cfgTrackCutQA, cfgJetQAHistos, cfgMCHistos, cfgMixedHistos, cfgJetHistos, cfgJetMCHistos, cfgJetdRHistos, cfgCutonTrig, cfgJetpT, cfgJetR, cfgJetdR, cfgJetMaxEta, cfgSingleJet, cfgReqJets, cfgForceTrueINELgt, cfgCentAxis, cfgBinsMixMult, cfgBinsMixVtx, binsDCAz, binsDCAxy, kaon, pion, kaonMC, pionMC, doprocessDataJets, doprocessMCJets, doprocessDataSameEvent, doprocessDataMixedEvent, doprocessSameEventMC, doprocessMixedEventMC, doprocessGen, doprocessGenJets, doprocessJetQA, cfgEventSelections, cfgRealTriggerMasks, cfgTriggerMasksTest1, cfgTriggerMasksTest2, cfgTriggerMasksTest3, perCollision, histos, nJetEvents, nJetMCEvents, nEvents, nEventsMix, nEventsMC, nEventsMCMix, nEventsGen, nprocessGenEvents, ndRtest, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:525:55: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:589:58: error: the const qualified parameter 'event' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:609:40: error: the const qualified parameter 'track' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:701:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:758:28: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:885:12: error: variable 'track1_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:885:25: error: variable 'track2_mass' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:965:73: error: the parameter 'lResonance' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:976:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1177:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInOO.cxx:1264:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/0f64d25a577609c15d846b15ff1a117acef2d513/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInOO.cxx:744:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInOO.cxx:967:25: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 65071bb at 2026-08-04 04:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:53:10: fatal error: stdlib: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 65071bb at 2026-08-04 04:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInOO.cxx:53:10: fatal error: stdlib: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@smaff92
smaff92 enabled auto-merge (squash) August 4, 2026 06:24

@smaff92 smaff92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the loops consts a la the O2linter request for your next PR. Thanks!

@smaff92
smaff92 merged commit 11b41a6 into AliceO2Group:master Aug 4, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants