[PWGHF] Improve tasks for B to JPsi analyses#16500
Open
fchinu wants to merge 4 commits into
Open
Conversation
fchinu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Collaborator
|
Hi @fchinu , can you please add brief descriptions of the bugs you're fixing in this PR? |
vkucera
reviewed
Jun 2, 2026
Comment on lines
+705
to
+713
| } else if (useJpsiPdgMass && !usePhiPdgMass) { | ||
| return RecoDecay::m(std::array{RecoDecay::pVec(pVecMuPos, pVecMuNeg), pVecKaPos, pVecKaNeg}, | ||
| std::array{o2::constants::physics::MassJPsi, o2::constants::physics::MassKPlus, o2::constants::physics::MassKPlus}); | ||
| } else if (!useJpsiPdgMass && usePhiPdgMass) { | ||
| return RecoDecay::m(std::array{pVecMuPos, pVecMuNeg, RecoDecay::pVec(pVecKaPos, pVecKaNeg)}, | ||
| std::array{o2::constants::physics::MassMuon, o2::constants::physics::MassMuon, o2::constants::physics::MassPhi}); | ||
| } else { | ||
| return RecoDecay::m(std::array{pVecMuPos, pVecMuNeg, pVecKaPos, pVecKaNeg}, | ||
| std::array{o2::constants::physics::MassMuon, o2::constants::physics::MassMuon, o2::constants::physics::MassKPlus, o2::constants::physics::MassKPlus}); |
Collaborator
There was a problem hiding this comment.
The else statements seem redundant here.
Collaborator
There was a problem hiding this comment.
It seems you only removed the last else while the other redundant ones are still there.
vkucera
reviewed
Jun 2, 2026
Comment on lines
+940
to
+942
| std::array<float, 3> const pVecMu0 = {candBp.pxProng0(), candBp.pyProng0(), candBp.pzProng0()}; | ||
| std::array<float, 3> const pVecMu1 = {candBp.pxProng1(), candBp.pyProng1(), candBp.pzProng1()}; | ||
| std::array<float, 3> const pVecKa = {candBp.pxProng2(), candBp.pyProng2(), candBp.pzProng2()}; |
Collaborator
There was a problem hiding this comment.
<float, 3> seems redundant here.
Collaborator
There was a problem hiding this comment.
You can actually also remove the = parts, as you did in invMassBplusToJpsiK.
vkucera
reviewed
Jun 2, 2026
vkucera
reviewed
Jun 2, 2026
vkucera
reviewed
Jun 2, 2026
vkucera
reviewed
Jun 2, 2026
Collaborator
|
It seems you could profit from |
Collaborator
|
Error while checking build/O2Physics/o2 for e7295f8 at 2026-06-03 05:55: Full log here. |
Contributor
Author
|
Hi @vkucera thanks for the comments! I have implemented them, and updated the description following the commit messages. |
Collaborator
|
Thanks @fchinu . Please see my further suggestions. |
Contributor
Author
Done, thanks! |
Collaborator
I don't see |
Contributor
Author
|
Sorry, I changed the ones you pointed me to, now everything should be updated |
Collaborator
|
In if (useJpsiPdgMass && usePhiPdgMass) {
return RecoDecay::m(...);
} else if (useJpsiPdgMass && !usePhiPdgMass) {
return RecoDecay::m(...);
} else if (!useJpsiPdgMass && usePhiPdgMass) {
return RecoDecay::m(...);
}
return RecoDecay::m(...);All the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have spotted a few bugs that were preventing the signals to be observed, and added a configurable to use J/Psi PDG mass instead of the reconstructed one when computing the B meson mass. (tagging @fgrosa)