Skip to content

[Common] Update centralityQa task#16490

Merged
ddobrigk merged 8 commits into
AliceO2Group:masterfrom
romainschotter:CentralityQa
Jun 2, 2026
Merged

[Common] Update centralityQa task#16490
ddobrigk merged 8 commits into
AliceO2Group:masterfrom
romainschotter:CentralityQa

Conversation

@romainschotter
Copy link
Copy Markdown
Collaborator

@romainschotter romainschotter commented Jun 1, 2026

  • Add configurables for event selections
  • Add process functions for all possible centrality/multiplicity percentile estimators
  • Add histograms previously filled in the deprecated multiplicityTable task (necessary for the MC centrality)

@njacazio @ercolessi @ddobrigk for your information

@github-actions github-actions Bot added the common label Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026 •
edited
Loading

O2 linter results: ❌ 2 errors, ⚠️ 21 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Update centralityQa task [Common] Update centralityQa task Jun 1, 2026
@alibuild alibuild mentioned this pull request Jun 1, 2026
Merged
@romainschotter
Merge pull request #72 from alibuild/alibot-cleanup-16490
2aeefb4 
Please consider the following formatting changes to AliceO2Group#16490
@romainschotter romainschotter marked this pull request as ready for review June 1, 2026 14:56
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 1, 2026

Error while checking build/O2Physics/o2 for 2aeefb4 at 2026-06-01 17:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityQa.cxx:670:17: error: unused variable 'mcCol' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 1, 2026

Error while checking build/O2Physics/staging for 2aeefb4 at 2026-06-01 17:05:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityQa.cxx:670:17: error: unused variable 'mcCol' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Jun 1, 2026
View reviewed changes
Comment thread Common/Tasks/centralityQa.cxx Outdated
Comment thread Common/Tasks/centralityQa.cxx Outdated
romainschotter and others added 2 commits June 2, 2026 00:08
@romainschotter @vkucera
Update Common/Tasks/centralityQa.cxx
5f18432 
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@romainschotter @vkucera
Update Common/Tasks/centralityQa.cxx
11aa580 
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@ddobrigk ddobrigk merged commit 1247fd7 into AliceO2Group:master Jun 2, 2026
11 of 13 checks passed
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Jun 2, 2026

@romainschotter @ddobrigk Please don't leave the errors unaddressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@romainschotter @alibuild @vkucera @ddobrigk