[Common] Add option to directly fetch centrality calibration histograms in centrality study#16476
Open
jesgum wants to merge 11 commits into
Open
[Common] Add option to directly fetch centrality calibration histograms in centrality study#16476jesgum wants to merge 11 commits into
jesgum wants to merge 11 commits into
Conversation
|
O2 linter results: ❌ 2 errors, |
Please consider the following formatting changes to AliceO2Group#16476
Collaborator
|
Error while checking build/O2Physics/staging for 432a81c at 2026-05-31 13:44: Full log here. |
Please consider the following formatting changes to AliceO2Group#16476
ddobrigk
approved these changes
Jun 1, 2026
vkucera
reviewed
Jun 1, 2026
| Configurable<std::string> irSource{"irSource", "ZNC hadronic", "Source of the interaction rate: (Recommended: pp --> T0VTX, Pb-Pb --> ZNC hadronic)"}; | ||
| Configurable<bool> irCrashOnNull{"irCrashOnNull", false, "Flag to avoid CTP RateFetcher crash."}; | ||
| Configurable<bool> fetchCentralityCalibration{"fetchCentralityCalibration", false, "Flag to fetch the centrality calibration within the task instead of the centrality table"}; | ||
| } ccdb; |
Collaborator
There was a problem hiding this comment.
This is a very misleading name, especially in combination with the renamed member mCcdb.
| mCcdb->setURL(ccdb.ccdbURL); | ||
| // mCcdb->setCaching(true); | ||
| // mCcdb->setLocalObjectValidityChecking(); | ||
| mCcdb->setFatalWhenNull(false); |
Collaborator
There was a problem hiding this comment.
Prefix m is reserved for members of classes.
| // ccdb->setCaching(true); | ||
| // ccdb->setLocalObjectValidityChecking(); | ||
| ccdb->setFatalWhenNull(false); | ||
| hCentralityFV0A = nullptr; |
Collaborator
There was a problem hiding this comment.
Why do you set it to nullptr again?
Comment on lines
229
to
237
| hCalibObjects = nullptr; | ||
| hVtxZFV0A = nullptr; | ||
| hVtxZFT0A = nullptr; | ||
| hVtxZFT0C = nullptr; | ||
| hVtxZNTracks = nullptr; | ||
| hVtxZNGlobals = nullptr; | ||
| hVtxZMFT = nullptr; | ||
| hVtxZFDDA = nullptr; | ||
| hVtxZFDDC = nullptr; |
Collaborator
There was a problem hiding this comment.
This should be done in the declaration.
| hCentralityMFT = dynamic_cast<TH1*>(hCentralityObjects->FindObject("hCalibZeqMFT")); | ||
|
|
||
| // won't capture null pointers -> explicitly check for those when attempting to evaluate | ||
| auto reportSuccess = [](TH1* hist, std::string name) { |
Collaborator
There was a problem hiding this comment.
Don't pass string by value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ddobrigk