Open
Conversation
PaolaVT
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
|
O2 linter results: ❌ 0 errors, |
vkucera
reviewed
Apr 7, 2026
Comment on lines
+158
to
+160
| static constexpr int PDGPion = PDG_t::kPiPlus; // Changed from kPiPlus | ||
| static constexpr int PDGKaon = PDG_t::kKPlus; // Changed from kKPlus | ||
| static constexpr int PDGProton = PDG_t::kProton; // Changed from kProton |
Collaborator
There was a problem hiding this comment.
Why don't you use the constants directly?
vkucera
reviewed
Apr 7, 2026
Comment on lines
151
to
156
| @@ -174,11 +155,10 @@ struct MultiplicityPt { | |||
| kNSpecies = 3 | |||
| }; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the PDG code handling that caused empty proton histograms. Additional changes were made to the analysis flow to ensure correct processing.