Skip to content

[PWGHF] Add Lc->pK0s channel in polarization task.#15635

Open
XXL-2025 wants to merge 5 commits intoAliceO2Group:masterfrom
XXL-2025:Lcpk0spPolarisation
Open

[PWGHF] Add Lc->pK0s channel in polarization task.#15635
XXL-2025 wants to merge 5 commits intoAliceO2Group:masterfrom
XXL-2025:Lcpk0spPolarisation

Conversation

@XXL-2025
Copy link
Copy Markdown

@XXL-2025 XXL-2025 commented Apr 2, 2026

@github-actions github-actions bot added the pwghf PWG-HF label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 5 disabled

@alibuild alibuild mentioned this pull request Apr 2, 2026
Closed
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 2, 2026

@XXL-2025 Who are you?

@XXL-2025 XXL-2025 force-pushed the Lcpk0spPolarisation branch from a72b372 to 4c9e4f8 Compare April 2, 2026 17:17
@XXL-2025
Copy link
Copy Markdown
Author

XXL-2025 commented Apr 2, 2026

@vkucera I am a new analyzer from China, and I’m currently learning the analysis from Mattia.

@XXL-2025 XXL-2025 closed this Apr 2, 2026
@vkucera vkucera mentioned this pull request Apr 2, 2026
Closed
@mfaggin
Copy link
Copy Markdown
Collaborator

mfaggin commented Apr 7, 2026

hi @vkucera, Xianxian is a student working with me. He is trying to implement the Lambdac->pK0s channel in the polarization task in O2Physics to do the analysis.
I asked him to open the PR as a draft on purpose not to trigger any notification to the reviewers because I wanted to check it first, and secondly I'd have introduced Xianxian once the PR would have been released for the review.

@mfaggin
Copy link
Copy Markdown
Collaborator

mfaggin commented Apr 7, 2026

now we do not manage to reopen the PR anymore, is it maybe because you @vkucera should act somehow? Can you please let us know? Thank you

@XXL-2025 XXL-2025 reopened this Apr 7, 2026
@XXL-2025 XXL-2025 force-pushed the Lcpk0spPolarisation branch from 4c9e4f8 to 28c7967 Compare April 7, 2026 07:58
@mfaggin
Copy link
Copy Markdown
Collaborator

mfaggin commented Apr 7, 2026

we understood how to reopen it, I'll review it later

mfaggin
mfaggin reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @XXL-2025 for the development. There are some adjustments to be done, please address my comments and test locally your code in both data and MC.

mfaggin
mfaggin reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @XXL-2025 for the development. There are some adjustments to be done, please address my comments and test locally your code in both data and MC.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 8, 2026

Hi @mfaggin @XXL-2025 , thanks for the clarification.
For the sake of transparent collaboration, I think that we should all show our names in our GitHub accounts and we should not accept pull requests from anonymous GitHub accounts.

mfaggin
mfaggin reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @XXL-2025 a few more adjustments needed, see the detailed comments. In general:

  • try to reduce as much as possible modifications in pieces of codes that might affect other analyses
  • do not remove comments / add useless new lines etc already present, to reduce entropy

PWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
{
/// check process functions
std::array<int, 13> processes = {doprocessDstar, doprocessDstarWithMl, doprocessLcToPKPi, doprocessLcToPKPiWithMl, doprocessDstarMc, doprocessDstarMcWithMl, doprocessLcToPKPiMc, doprocessLcToPKPiMcWithMl, doprocessLcToPKPiBackgroundMcWithMl, doprocessDstarInPbPb, doprocessDstarWithMlInPbPb, doprocessDstarMcInPbPb, doprocessDstarMcWithMlInPbPb};

Copy link
Copy Markdown
Collaborator

@mfaggin mfaggin Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still new line present compared to the original version, please remove it

@alibuild alibuild mentioned this pull request Apr 10, 2026
Closed
@XXL-2025
Copy link
Copy Markdown
Author

XXL-2025 commented Apr 10, 2026

Thanks a lot for detailed comments.
This is the revised version.

mfaggin
mfaggin reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @XXL-2025 , almost there :)
Still a few comments from my side, after implementing them retry also to compile locally and rerun on both data and MC

@mfaggin mfaggin marked this pull request as ready for review April 10, 2026 15:27
@mfaggin
Copy link
Copy Markdown
Collaborator

mfaggin commented Apr 10, 2026

With this PR we want to add the Lambdac->pK0s channel in the polarization task.
The work has been done by Xianxian, who is working with me for this analysis.
@fgrosa since you and Mingze use the same code, I'd ask you to have an independent look. The developments should be basically harmless for you, but better to have a further look from your side.

Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfaggin mfaggin mfaggin left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XXL-2025 @vkucera @mfaggin