[PWGUD] MC analysis for flow by miedema-11 · Pull Request #15626 · AliceO2Group/O2Physics

miedema-11 · 2026-04-02T13:20:55Z

No description provided.

github-actions · 2026-04-02T13:21:14Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-04-02T13:31:44Z

Error while checking build/O2Physics/o2 for fc7b1e9 at 2026-04-02 15:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowMcUpc.cxx:131:16: error: unused variable 'phi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowMcUpc.cxx:171:14: error: unused variable 'phi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowMcUpc.cxx:95:33: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

Comment out the calculation of phi for mcParticles and tracks.

alibuild · 2026-04-02T19:12:14Z

Error while checking build/O2Physics/o2 for aad8ae2 at 2026-04-02 21:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowMcUpc.cxx:129:16: error: unused variable 'phi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowMcUpc.cxx:169:14: error: unused variable 'phi' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

miedema-11 · 2026-04-03T01:54:09Z

sorry for this error, but I am not sure what to do about the CMakeList.cxx

miedema-11 · 2026-04-03T16:46:49Z

If it is caused by my code, please let me know. Thank you so much

alibuild · 2026-04-03T17:36:24Z

Error while checking build/O2Physics/o2 for f179a75 at 2026-04-03 19:36:

No log files found

Full log here.

rolavick · 2026-04-06T15:45:27Z

Dear @miedema-11,
you can ignore the CMAKELIST errors, they are not related to your changes. I have another question. In your new file, do you follow the same convention for your headers as in the other files? (usage of <> and "")
Roman

vkucera · 2026-04-06T18:09:14Z

PWGUD/Tasks/flowCumulantsUpc.cxx

Why don't you fix the error instead of disabling it?

vkucera · 2026-04-06T18:09:40Z

PWGUD/Tasks/flowCumulantsUpc.cxx

Magic bit numbers.

vkucera · 2026-04-06T18:10:38Z

PWGUD/Tasks/flowMcUpc.cxx

+#include "ReconstructionDataFormats/Track.h"
+#include <CCDB/BasicCCDBManager.h>
+
+#include <TF1.h>


I don't see any mention of TF1. How did you verify that you included what you used?

vkucera · 2026-04-06T18:10:53Z

PWGUD/Tasks/flowMcUpc.cxx

+#include "Common/Core/trackUtilities.h"
+#include "Common/DataModel/TrackSelectionTables.h"
+
+#include "Framework/ASoAHelpers.h"


Wrong format.

vkucera · 2026-04-06T18:11:43Z

PWGUD/Tasks/flowMcUpc.cxx

+  // }
+
+  template <typename TTrack>
+  bool trackSelected(TTrack track)


Don't copy tracks.

vkucera · 2026-04-06T18:12:07Z

PWGUD/Tasks/flowMcUpc.cxx

+  bool trackSelected(TTrack track)
+  {
+    auto momentum = std::array<double, 3>{track.px(), track.py(), track.pz()};
+    double pt = RecoDecay::pt(momentum);


Use track.pt().

vkucera · 2026-04-06T18:13:58Z

PWGUD/Tasks/flowMcUpc.cxx

+
+      for (auto const& mcParticle : mcParticles) {
+        auto momentum = std::array<double, 3>{mcParticle.px(), mcParticle.py(), mcParticle.pz()};
+        double pt = RecoDecay::pt(momentum);


Use mcParticle.pt().

vkucera · 2026-04-06T18:14:08Z

PWGUD/Tasks/flowMcUpc.cxx

+        auto momentum = std::array<double, 3>{mcParticle.px(), mcParticle.py(), mcParticle.pz()};
+        double pt = RecoDecay::pt(momentum);
+        // double phi = RecoDecay::phi(momentum);
+        double eta = RecoDecay::eta(momentum);


Use mcParticle.eta().

vkucera · 2026-04-06T18:14:28Z

PWGUD/Tasks/flowMcUpc.cxx

+        double eta = RecoDecay::eta(momentum);
+        // focus on bulk: e, mu, pi, k, p
+        int pdgCode = std::abs(mcParticle.pdgCode());
+        if (pdgCode != PDG_t::kElectron && pdgCode != PDG_t::kMuonMinus && pdgCode != PDG_t::kPiPlus && pdgCode != kKPlus && pdgCode != PDG_t::kProton)


Suggested change

if (pdgCode != PDG_t::kElectron && pdgCode != PDG_t::kMuonMinus && pdgCode != PDG_t::kPiPlus && pdgCode != kKPlus && pdgCode != PDG_t::kProton)

if (pdgCode != PDG_t::kElectron && pdgCode != PDG_t::kMuonMinus && pdgCode != PDG_t::kPiPlus && pdgCode != PDG_t::kKPlus && pdgCode != PDG_t::kProton)

miedema-11 added 3 commits April 2, 2026 17:04

add event consistency flag

d616170

add event consistency flag

913605e

MC analysis for flow

fc7b1e9

miedema-11 requested review from alibuild, amatyja and rolavick as code owners April 2, 2026 13:20

github-actions bot added the pwgud label Apr 2, 2026

github-actions bot changed the title ~~MC analysis for flow~~ [PWGUD] MC analysis for flow Apr 2, 2026

Refactor includes and update process functions

384a2fd

alibuild mentioned this pull request Apr 2, 2026

Please consider the following formatting changes to #15626 miedema-11/O2Physics#4

Closed

miedema-11 marked this pull request as draft April 2, 2026 14:23

Reorganize includes and clean up code structure

aad8ae2

miedema-11 marked this pull request as ready for review April 2, 2026 14:37

miedema-11 marked this pull request as draft April 2, 2026 15:36

Comment out phi calculation in flowMcUpc.cxx

f179a75

Comment out the calculation of phi for mcParticles and tracks.

miedema-11 marked this pull request as ready for review April 2, 2026 16:41

vkucera reviewed Apr 6, 2026

View reviewed changes

	if (pdgCode != PDG_t::kElectron && pdgCode != PDG_t::kMuonMinus && pdgCode != PDG_t::kPiPlus && pdgCode != kKPlus && pdgCode != PDG_t::kProton)
	if (pdgCode != PDG_t::kElectron && pdgCode != PDG_t::kMuonMinus && pdgCode != PDG_t::kPiPlus && pdgCode != PDG_t::kKPlus && pdgCode != PDG_t::kProton)

Conversation

miedema-11 commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Apr 2, 2026

Uh oh!

alibuild commented Apr 2, 2026

Uh oh!

miedema-11 commented Apr 3, 2026

Uh oh!

miedema-11 commented Apr 3, 2026

Uh oh!

alibuild commented Apr 3, 2026

Uh oh!

rolavick commented Apr 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 2, 2026 •

edited

Loading