Skip to content

[ALICE3] Fix crashes from otf decayer #15062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 2 commits into from
Feb 20, 2026
+54 −46
Merged

[ALICE3] Fix crashes from otf decayer #15062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a16f98
Fix crashes from when decay products have NaN's
jesgum Feb 19, 2026
f3eb846
formatting
jesgum Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ALICE3/DataModel/OTFMCParticle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ DECLARE_SOA_COLUMN(IsPrimary, isPrimary, bool);

} // namespace otfmcparticle

DECLARE_SOA_TABLE_FULL(McParticlesWithDau, "McParticlesWithDau", "AOD", "MCPARTICLEWITHDAU",
DECLARE_SOA_TABLE_FULL(McPartsWithDau, "McPartsWithDau", "AOD", "MCPARTSWITHDAU",
o2::soa::Index<>,
mcparticle::McCollisionId,
mcparticle::PdgCode,
Expand Down Expand Up @@ -69,7 +69,7 @@ DECLARE_SOA_TABLE_FULL(McParticlesWithDau, "McParticlesWithDau", "AOD", "MCPARTI
mcparticle::GetProcess<mcparticle::Flags, mcparticle::StatusCode>,
mcparticle::IsPhysicalPrimary<mcparticle::Flags>);

using McParticleWithDau = McParticlesWithDau::iterator;
using McPartWithDau = McPartsWithDau::iterator;

} // namespace o2::aod

Expand Down
76 changes: 42 additions & 34 deletions ALICE3/TableProducer/OTF/onTheFlyDecayer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,13 @@
#include "ALICE3/Core/TrackUtilities.h"
#include "ALICE3/DataModel/OTFMCParticle.h"

#include <CCDB/BasicCCDBManager.h>
#include <CommonConstants/MathConstants.h>
#include <CommonConstants/PhysicsConstants.h>
#include <DCAFitter/DCAFitterN.h>
#include <DataFormatsParameters/GRPMagField.h>
#include <DetectorsBase/Propagator.h>
#include <DetectorsVertexing/PVertexer.h>
#include <DetectorsVertexing/PVertexerHelpers.h>
#include <Field/MagneticField.h>
#include <Framework/AnalysisDataModel.h>
#include <Framework/AnalysisTask.h>
#include <Framework/HistogramRegistry.h>
#include <Framework/O2DatabasePDGPlugin.h>
#include <Framework/StaticFor.h>
#include <Framework/runDataProcessing.h>
#include <ReconstructionDataFormats/DCA.h>
#include <SimulationDataFormat/InteractionSampler.h>

#include <TPDGCode.h>

Expand Down Expand Up @@ -69,14 +59,15 @@ static const std::vector<int> pdgCodes{kK0Short,
kOmegaPlusBar};

struct OnTheFlyDecayer {
Produces<aod::McParticlesWithDau> tableMcParticlesWithDau;
Produces<aod::McPartsWithDau> tableMcParticlesWithDau;

o2::upgrade::Decayer decayer;
Service<o2::framework::O2DatabasePDG> pdgDB;
std::map<int, std::vector<o2::upgrade::OTFParticle>> mDecayDaughters;

Configurable<int> seed{"seed", 0, "Set seed for particle decayer"};
Configurable<float> magneticField{"magneticField", 20., "Magnetic field (kG)"};
Configurable<float> maxEta{"maxEta", 2.5, "Only decay particles that appear within selected eta range"};
Configurable<LabeledArray<int>> enabledDecays{"enabledDecays",
{DefaultParameters[0], NumDecays, NumParameters, particleNames, parameterNames},
"Enable option for particle to be decayed: 0 - no, 1 - yes"};
Expand Down Expand Up @@ -122,6 +113,15 @@ struct OnTheFlyDecayer {
y(y),
isAlive(isAlive),
isPrimary(isPrimary) {}

bool hasNaN() const
{
return std::isnan(px) || std::isnan(py) || std::isnan(pz) || std::isnan(e) ||
std::isnan(vx) || std::isnan(vy) || std::isnan(vz) || std::isnan(vt) ||
std::isnan(phi) || std::isnan(eta) || std::isnan(pt) || std::isnan(p) ||
std::isnan(y) || std::isnan(weight);
}

int collisionId;
int pdgCode;
int statusCode;
Expand All @@ -148,6 +148,10 @@ struct OnTheFlyDecayer {
}
}

auto hNaNBookkeeping = histos.add<TH1>("hNaNBookkeeping", "hNaNBookkeeping", kTH1D, {{2, -0.5, 1.5}});
hNaNBookkeeping->GetXaxis()->SetBinLabel(1, "OK");
hNaNBookkeeping->GetXaxis()->SetBinLabel(2, "NaN");

histos.add("K0S/hGenK0S", "hGenK0S", kTH1D, {axisPt});
histos.add("Lambda/hGenLambda", "hGenLambda", kTH1D, {axisPt});
histos.add("AntiLambda/hGenAntiLambda", "hGenAntiLambda", kTH1D, {axisPt});
Expand Down Expand Up @@ -175,30 +179,29 @@ struct OnTheFlyDecayer {
mcParticlesAlice3.clear();
u_int64_t nStoredDaughters = 0;
for (int index{0}; index < static_cast<int>(mcParticles.size()); ++index) {
const auto& particle = mcParticles.iteratorAt(index);
std::vector<o2::upgrade::OTFParticle> decayDaughters;
static constexpr int MaxNestedDecays = 10;
int nDecays = 0;
if (canDecay(particle.pdgCode())) {
const auto& particle = mcParticles.rawIteratorAt(index);
std::vector<o2::upgrade::OTFParticle> decayDaughters, decayStack;
if (canDecay(particle.pdgCode()) && std::abs(particle.eta()) < maxEta) {
o2::track::TrackParCov o2track;
o2::upgrade::convertMCParticleToO2Track(particle, o2track, pdgDB);
decayDaughters = decayer.decayParticle(pdgDB, o2track, particle.pdgCode());
for (size_t idau{0}; idau < decayDaughters.size(); ++idau) {
o2::upgrade::OTFParticle dau = decayDaughters[idau];
decayStack = decayer.decayParticle(pdgDB, o2track, particle.pdgCode());
while (!decayStack.empty()) {
o2::upgrade::OTFParticle otfParticle = decayStack.back();
decayStack.pop_back();

const bool stable = !canDecay(otfParticle.pdgCode());
otfParticle.setIsAlive(stable);
decayDaughters.push_back(otfParticle);

if (stable) {
continue;
}

o2::track::TrackParCov dauTrack;
o2::upgrade::convertOTFParticleToO2Track(dau, dauTrack, pdgDB);
if (canDecay(dau.pdgCode())) {
dau.setIsAlive(false);
std::vector<o2::upgrade::OTFParticle> cascadingDaughers = decayer.decayParticle(pdgDB, dauTrack, dau.pdgCode());
for (size_t idaudau{0}; idaudau < cascadingDaughers.size(); ++idaudau) {
o2::upgrade::OTFParticle daudau = cascadingDaughers[idaudau];
decayDaughters.push_back(daudau);
if (MaxNestedDecays < ++nDecays) {
LOG(error) << "Seemingly stuck trying to perpetually decay products from pdg: " << particle.pdgCode();
}
}
} else {
dau.setIsAlive(true);
o2::upgrade::convertOTFParticleToO2Track(otfParticle, dauTrack, pdgDB);
std::vector<o2::upgrade::OTFParticle> daughters = decayer.decayParticle(pdgDB, dauTrack, otfParticle.pdgCode());
for (o2::upgrade::OTFParticle dau : daughters) {
decayStack.push_back(dau);
}
}

Expand Down Expand Up @@ -338,7 +341,7 @@ struct OnTheFlyDecayer {
// TODO: Particle status code
// TODO: Expression columns
// TODO: vt
auto mother = mcParticles.iteratorAt(index);
auto mother = mcParticles.rawIteratorAt(index);
mcParticlesAlice3.push_back(McParticleAlice3{mother.mcCollisionId(), dau.pdgCode(), 1,
-1, index, index, daughtersIdSlice[0], daughtersIdSlice[1], mother.weight(),
dau.px(), dau.py(), dau.pz(), dau.e(),
Expand All @@ -348,8 +351,13 @@ struct OnTheFlyDecayer {
}

for (const auto& particle : mcParticlesAlice3) {
std::span<const int> motherSpan(particle.mothersIds, 2);
if (particle.hasNaN()) {
histos.fill(HIST("hNaNBookkeeping"), 1);
continue;
}

histos.fill(HIST("hNaNBookkeeping"), 0);
std::span<const int> motherSpan(particle.mothersIds, 2);
tableMcParticlesWithDau(particle.collisionId, particle.pdgCode, particle.statusCode,
particle.flags, motherSpan, particle.daughtersIdSlice, particle.weight,
particle.px, particle.py, particle.pz, particle.e,
Expand Down
6 changes: 3 additions & 3 deletions ALICE3/TableProducer/OTF/onTheFlyTracker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ struct OnTheFlyTracker {

float dNdEta = 0.f; // Charged particle multiplicity to use in the efficiency evaluation
std::pair<float, float> vertexReconstructionEfficiencyCounters = {0, 0}; // {nVerticesWithMoreThan2Contributors, nVerticesReconstructed}
void processWithLUTs(aod::McCollision const& mcCollision, aod::McParticles const& mcParticles, int const& icfg)
void processWithLUTs(aod::McCollision const& mcCollision, aod::McParticles const& mcParticles, const int icfg)
{
vertexReconstructionEfficiencyCounters.first += 1;
const int lastTrackIndex = tableStoredTracksCov.lastIndex() + 1; // bookkeep the last added track
Expand Down Expand Up @@ -1736,7 +1736,7 @@ struct OnTheFlyTracker {
}
}

void processConfigurationDev(aod::McCollision const& mcCollision, aod::McParticlesWithDau const& mcParticles, int const& icfg)
void processConfigurationDev(aod::McCollision const& mcCollision, aod::McPartsWithDau const& mcParticles, const int icfg)
{
// const int lastTrackIndex = tableStoredTracksCov.lastIndex() + 1; // bookkeep the last added track
const std::string histPath = "Configuration_" + std::to_string(icfg) + "/";
Expand Down Expand Up @@ -1991,7 +1991,7 @@ struct OnTheFlyTracker {
}
}

void processDecayer(aod::McCollision const& mcCollision, aod::McParticlesWithDau const& mcParticles)
void processDecayer(aod::McCollision const& mcCollision, aod::McPartsWithDau const& mcParticles)
{
for (size_t icfg = 0; icfg < mSmearer.size(); ++icfg) {
processConfigurationDev(mcCollision, mcParticles, static_cast<int>(icfg));
Expand Down
2 changes: 1 addition & 1 deletion ALICE3/Tasks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ o2physics_add_dpl_workflow(alice3-dq-efficiency
COMPONENT_NAME Analysis)

o2physics_add_dpl_workflow(alice3-decayer-qa
SOURCES alice3DecayerQA.cxx
SOURCES alice3DecayerQa.cxx
PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore
COMPONENT_NAME Analysis)
12 changes: 6 additions & 6 deletions ALICE3/Tasks/alice3DecayerQA.cxx → ALICE3/Tasks/alice3DecayerQa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ struct Alice3DecayerQA {
Partition<aod::McParticles> trueKa = aod::mcparticle::pdgCode == static_cast<int>(kKMinus);
Partition<aod::McParticles> truePr = aod::mcparticle::pdgCode == static_cast<int>(kProton);

Partition<aod::McParticlesWithDau> trueElWithDau = aod::mcparticle::pdgCode == static_cast<int>(kElectron);
Partition<aod::McParticlesWithDau> trueMuWithDau = aod::mcparticle::pdgCode == static_cast<int>(kMuonMinus);
Partition<aod::McParticlesWithDau> truePiWithDau = aod::mcparticle::pdgCode == static_cast<int>(kPiPlus);
Partition<aod::McParticlesWithDau> trueKaWithDau = aod::mcparticle::pdgCode == static_cast<int>(kKMinus);
Partition<aod::McParticlesWithDau> truePrWithDau = aod::mcparticle::pdgCode == static_cast<int>(kProton);
Partition<aod::McPartsWithDau> trueElWithDau = aod::mcparticle::pdgCode == static_cast<int>(kElectron);
Partition<aod::McPartsWithDau> trueMuWithDau = aod::mcparticle::pdgCode == static_cast<int>(kMuonMinus);
Partition<aod::McPartsWithDau> truePiWithDau = aod::mcparticle::pdgCode == static_cast<int>(kPiPlus);
Partition<aod::McPartsWithDau> trueKaWithDau = aod::mcparticle::pdgCode == static_cast<int>(kKMinus);
Partition<aod::McPartsWithDau> truePrWithDau = aod::mcparticle::pdgCode == static_cast<int>(kProton);

void init(o2::framework::InitContext&)
{
Expand Down Expand Up @@ -123,7 +123,7 @@ struct Alice3DecayerQA {
}
}

void processMCWithDau(const aod::McCollision&, const aod::McParticlesWithDau& particles)
void processMCWithDau(const aod::McCollision&, const aod::McPartsWithDau& particles)
{
for (const auto& particle : trueElWithDau) {
histos.fill(HIST("MCWithDau/hElPt"), particle.pt());
Expand Down
Loading