[PWGJE] [EMCAL] fix zorro event selection in emc correction framework#15047
Merged
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom Feb 20, 2026
Merged
[PWGJE] [EMCAL] fix zorro event selection in emc correction framework#15047mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
Conversation
fjonasALICE
requested review from
alibuild,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
[PWGJE] Please consider the following formatting changes to AliceO2Group#15047
nzardosh
approved these changes
Feb 19, 2026
Collaborator
Author
|
Arm build seems to be stuck ? |
Collaborator
Ciao @ktf do you know if there is a problem with the test machine? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorders the selection of events using the zorro software trigger. Until now, filling of emcalcollisionmatch was also skipped whenever the software trigger is not fulfilled, however, this breaks joining of the emcalcollisionmatch table with collision table in analysis tasks, as the length might be different after zorro selection. We therefore now no longer skip filling of this table. All other tables (including cluster tables) are still only filled when zorro software trigger is fired (if desired)