Skip to content

[PWGCF] Adding the option to remap dead channels #14414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MartijnLaarhoven wants to merge 5 commits into from
+29 −0
Closed

[PWGCF] Adding the option to remap dead channels #14414

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58b1428
Adding option to reject part of the FT0 detectors
MartijnLaarhoven Dec 19, 2025
35066df
Merge pull request #2 from MartijnLaarhoven/MartijnLaarhoven-patch-1
MartijnLaarhoven Dec 19, 2025
3a07128
Merge branch 'AliceO2Group:master' into master
MartijnLaarhoven Jan 7, 2026
95170ad
Adding the option to remap dead channels
MartijnLaarhoven Jan 7, 2026
30dd963
Merge pull request #3 from MartijnLaarhoven/MartijnLaarhoven-patch-2
MartijnLaarhoven Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ struct LongRangeDihadronCor {
O2_DEFINE_CONFIGURABLE(cfgRejectFT0AOutside, bool, false, "Rejection of outer ring channels of the FT0A detector")
O2_DEFINE_CONFIGURABLE(cfgRejectFT0CInside, bool, false, "Rejection of inner ring channels of the FT0C detector")
O2_DEFINE_CONFIGURABLE(cfgRejectFT0COutside, bool, false, "Rejection of outer ring channels of the FT0C detector")
O2_DEFINE_CONFIGURABLE(cfgRemapFT0ADeadChannels, bool, false, "If true, remap FT0A channels 60-63 to amplitudes from 92-95 respectively")
O2_DEFINE_CONFIGURABLE(cfgRemapFT0CDeadChannels, bool, false, "If true, remap FT0C channels 177->145, 176->144, 178->146, 179->147, 139->115")
struct : ConfigurableGroup {
O2_DEFINE_CONFIGURABLE(cfgMultCentHighCutFunction, std::string, "[0] + [1]*x + [2]*x*x + [3]*x*x*x + [4]*x*x*x*x + 10.*([5] + [6]*x + [7]*x*x + [8]*x*x*x + [9]*x*x*x*x)", "Functional for multiplicity correlation cut");
O2_DEFINE_CONFIGURABLE(cfgMultCentLowCutFunction, std::string, "[0] + [1]*x + [2]*x*x + [3]*x*x*x + [4]*x*x*x*x - 3.*([5] + [6]*x + [7]*x*x + [8]*x*x*x + [9]*x*x*x*x)", "Functional for multiplicity correlation cut");
Expand Down Expand Up @@ -250,6 +252,12 @@ struct LongRangeDihadronCor {
kFT0COuterRingMin = 144,
kFT0COuterRingMax = 207
};
enum MirroringConstant {
kFT0AOuterMirror = 32,
kFT0AInnerMirror = 16,
kFT0COuterMirror = 32,
kFT0CInnerMirror = 24
};
Comment on lines +255 to +260
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum constant name "MirroringConstant" is grammatically incorrect. It should be "MirroringConstants" (plural) since the enum defines multiple constants, following the convention used by other enums in this file like "DetectorChannels".

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@MartijnLaarhoven MartijnLaarhoven Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

std::array<float, 6> tofNsigmaCut;
std::array<float, 6> itsNsigmaCut;
std::array<float, 6> tpcNsigmaCut;
Expand Down Expand Up @@ -653,6 +661,19 @@ struct LongRangeDihadronCor {
id = ft0.channelC()[iCh];
id = id + Ft0IndexA;
ampl = ft0.amplitudeC()[iCh];
if (cfgRemapFT0CDeadChannels) {
if (id == 115) {
int dead_id = id + kFT0CInnerMirror;
registry.fill(HIST("FT0Amp"), dead_id, ampl);
ampl = ampl / cstFT0RelGain[iCh];
registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);
} else if (id >= 144 && id <= 147) {
int dead_id = id + kFT0COuterMirror;
registry.fill(HIST("FT0Amp"), dead_id, ampl);
ampl = ampl / cstFT0RelGain[iCh];
registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);
}
}
Comment on lines +664 to +676
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remapping logic appears to be inverted. According to the configuration description, dead channels (177, 176, 178, 179, 139) should receive amplitudes from their working mirror channels (145, 144, 146, 147, 115). However, the current implementation checks if the channel ID is a working channel (115 or 144-147) and then fills histograms for the dead channels. This means:

  1. The dead channels themselves are never processed when encountered
  2. Working channels have their amplitudes duplicated to dead channel histograms
  3. The gain correction is applied using the wrong channel index (iCh corresponds to the working channel, not the dead one)

The logic should instead check if the current channel is a dead channel, calculate which working channel to read from, and use that working channel's amplitude.

Copilot uses AI. Check for mistakes.
if ((cfgRejectFT0CInside && (id >= kFT0CInnerRingMin && id <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (id >= kFT0COuterRingMin && id <= kFT0COuterRingMax)))
ampl = 0.;
registry.fill(HIST("FT0Amp"), id, ampl);
Expand All @@ -661,6 +682,14 @@ struct LongRangeDihadronCor {
} else if (fitType == kFT0A) {
id = ft0.channelA()[iCh];
ampl = ft0.amplitudeA()[iCh];
if (cfgRemapFT0ADeadChannels) {
if (id >= 92 && id <= 95) {
int dead_id = id - kFT0AOuterMirror;
registry.fill(HIST("FT0Amp"), dead_id, ampl);
ampl = ampl / cstFT0RelGain[iCh];
registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);
}
}
Comment on lines +685 to +692
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remapping logic appears to be inverted. According to the configuration description, dead channels (60-63) should receive amplitudes from their working mirror channels (92-95). However, the current implementation checks if the channel ID is a working channel (92-95) and then fills histograms for the dead channels (60-63). This means:

  1. The dead channels themselves are never processed when encountered
  2. Working channels have their amplitudes duplicated to dead channel histograms
  3. The gain correction is applied using the wrong channel index (iCh corresponds to the working channel, not the dead one)

The logic should instead check if the current channel is a dead channel, calculate which working channel to read from, and use that working channel's amplitude.

Copilot uses AI. Check for mistakes.
if ((cfgRejectFT0AInside && (id >= kFT0AInnerRingMin && id <= kFT0AInnerRingMax)) || (cfgRejectFT0AOutside && (id >= kFT0AOuterRingMin && id <= kFT0AOuterRingMax)))
ampl = 0.;
registry.fill(HIST("FT0Amp"), id, ampl);
Expand Down
Loading